sync: remove use of protobuf extensions in protocol to reduce static init overhead.

chrome/browser/webdata/autofill_profile_syncable_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/autofill_profile_syncable_service.h"
 
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/form_group.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/api/sync_error.h"
+#include "chrome/browser/sync/protocol/sync.pb.h"
 #include "chrome/browser/webdata/autofill_table.h"
 #include "chrome/browser/webdata/web_data_service.h"
 #include "chrome/browser/webdata/web_database.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/guid.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 
 using content::BrowserThread;
@@ skipping 165 matching lines @@
   for (SyncChangeList::const_iterator i = change_list.begin();
        i != change_list.end(); ++i) {
     DCHECK(i->IsValid());
     switch (i->change_type()) {
       case SyncChange::ACTION_ADD:
       case SyncChange::ACTION_UPDATE:
         CreateOrUpdateProfile(i->sync_data(), &profiles_map_, &bundle);
         break;
       case SyncChange::ACTION_DELETE: {
         std::string guid = i->sync_data().GetSpecifics().
-             GetExtension(sync_pb::autofill_profile).guid();
+             autofill_profile().guid();
         bundle.profiles_to_delete.push_back(guid);
         profiles_map_.erase(guid);
       } break;
       default:
         NOTREACHED() << "Unexpected sync change state.";
         return SyncError(FROM_HERE, "ProcessSyncChanges failed on ChangeType " +
                          SyncChange::ChangeTypeToString(i->change_type()),
                          syncable::AUTOFILL_PROFILE);
     }
   }
@@ skipping 83 matching lines @@
                                 specifics.phone_home_whole_number(),
                                 profile) || diff;
   return diff;
 }
 
 // static
 void AutofillProfileSyncableService::WriteAutofillProfile(
     const AutofillProfile& profile,
     sync_pb::EntitySpecifics* profile_specifics) {
   sync_pb::AutofillProfileSpecifics* specifics =
-      profile_specifics->MutableExtension(sync_pb::autofill_profile);
+      profile_specifics->mutable_autofill_profile();
 
   DCHECK(guid::IsValidGUID(profile.guid()));
 
   // Reset all multi-valued fields in the protobuf.
   specifics->clear_name_first();
   specifics->clear_name_middle();
   specifics->clear_name_last();
   specifics->clear_email_address();
   specifics->clear_phone_home_whole_number();
 
@@ skipping 42 matching lines @@
 AutofillProfileSyncableService::GUIDToProfileMap::iterator
 AutofillProfileSyncableService::CreateOrUpdateProfile(
     const SyncData& data, GUIDToProfileMap* profile_map, DataBundle* bundle) {
   DCHECK(profile_map);
   DCHECK(bundle);
 
   DCHECK_EQ(syncable::AUTOFILL_PROFILE, data.GetDataType());
 
   const sync_pb::EntitySpecifics& specifics = data.GetSpecifics();
   const sync_pb::AutofillProfileSpecifics& autofill_specifics(
-      specifics.GetExtension(sync_pb::autofill_profile));
+      specifics.autofill_profile());
 
   GUIDToProfileMap::iterator it = profile_map->find(
         autofill_specifics.guid());
   if (it != profile_map->end()) {
     // Some profile that already present is synced.
     if (OverwriteProfileWithServerData(autofill_specifics, it->second))
       bundle->profiles_to_update.push_back(it->second);
   } else {
     // New profile synced.
     AutofillProfile* new_profile(
@@ skipping 125 matching lines @@
 }
 
 AutofillTable* AutofillProfileSyncableService::GetAutofillTable() const {
   return web_data_service_->GetDatabase()->GetAutofillTable();
 }
 
 AutofillProfileSyncableService::DataBundle::DataBundle() {}
 
 AutofillProfileSyncableService::DataBundle::~DataBundle() {
 }