sync: remove use of protobuf extensions in protocol to reduce static init overhead.

chrome/browser/sync/protocol/proto_value_conversions.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Keep this file in sync with the .proto files in this directory.
 
 #include "chrome/browser/sync/protocol/proto_value_conversions.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 74 matching lines @@
 #define SET_INT64_REP(field) SET_REP(field, MakeInt64Value)
 #define SET_STR(field) SET(field, Value::CreateStringValue)
 #define SET_STR_REP(field) \
   value->Set(#field, \
              MakeRepeatedValue<const std::string&, \
                                google::protobuf::RepeatedPtrField< \
                                    std::string >, \
                                StringValue>(proto.field(), \
                                             Value::CreateStringValue))
 
-#define SET_EXTENSION(ns, field, fn)                                    \
+#define SET_EXTENSION(field, fn)                                    \

[akalin, 2012/03/02 23:56:49]

line up \s

[akalin, 2012/03/02 23:56:49]

SET_EXTENSION -> SET_SPECIFICS/SET_FIELD?

   do {                                                                  \
-    if (specifics.HasExtension(ns::field)) {                            \
-      value->Set(#field, fn(specifics.GetExtension(ns::field)));        \
+    if (specifics.has_##field()) {                            \
+      value->Set(#field, fn(specifics.field()));        \
     }                                                                   \
   } while (0)
 
 // If you add another macro, don't forget to add an #undef at the end
 // of this file, too.
 
 DictionaryValue* EncryptedDataToValue(const sync_pb::EncryptedData& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET_STR(key_name);
   // TODO(akalin): Shouldn't blob be of type bytes instead of string?
@@ skipping 263 matching lines @@
   SET_STR(title);
   SET_BOOL(hidden);
   SET_INT64_REP(visits);
   SET_INT32_REP(visit_transitions);
   return value;
 }
 
 DictionaryValue* EntitySpecificsToValue(
     const sync_pb::EntitySpecifics& specifics) {
   DictionaryValue* value = new DictionaryValue();
-  SET_EXTENSION(sync_pb, app, AppSpecificsToValue);
-  SET_EXTENSION(sync_pb, app_notification, AppNotificationToValue);
-  SET_EXTENSION(sync_pb, app_setting, AppSettingSpecificsToValue);
-  SET_EXTENSION(sync_pb, autofill, AutofillSpecificsToValue);
-  SET_EXTENSION(sync_pb, autofill_profile, AutofillProfileSpecificsToValue);
-  SET_EXTENSION(sync_pb, bookmark, BookmarkSpecificsToValue);
-  SET_EXTENSION(sync_pb, extension, ExtensionSpecificsToValue);
-  SET_EXTENSION(sync_pb, extension_setting, ExtensionSettingSpecificsToValue);
-  SET_EXTENSION(sync_pb, nigori, NigoriSpecificsToValue);
-  SET_EXTENSION(sync_pb, password, PasswordSpecificsToValue);
-  SET_EXTENSION(sync_pb, preference, PreferenceSpecificsToValue);
-  SET_EXTENSION(sync_pb, search_engine, SearchEngineSpecificsToValue);
-  SET_EXTENSION(sync_pb, session, SessionSpecificsToValue);
-  SET_EXTENSION(sync_pb, theme, ThemeSpecificsToValue);
-  SET_EXTENSION(sync_pb, typed_url, TypedUrlSpecificsToValue);
+  SET_EXTENSION(app, AppSpecificsToValue);
+  SET_EXTENSION(app_notification, AppNotificationToValue);
+  SET_EXTENSION(app_setting, AppSettingSpecificsToValue);
+  SET_EXTENSION(autofill, AutofillSpecificsToValue);
+  SET_EXTENSION(autofill_profile, AutofillProfileSpecificsToValue);
+  SET_EXTENSION(bookmark, BookmarkSpecificsToValue);
+  SET_EXTENSION(extension, ExtensionSpecificsToValue);
+  SET_EXTENSION(extension_setting, ExtensionSettingSpecificsToValue);
+  SET_EXTENSION(nigori, NigoriSpecificsToValue);
+  SET_EXTENSION(password, PasswordSpecificsToValue);
+  SET_EXTENSION(preference, PreferenceSpecificsToValue);
+  SET_EXTENSION(search_engine, SearchEngineSpecificsToValue);
+  SET_EXTENSION(session, SessionSpecificsToValue);
+  SET_EXTENSION(theme, ThemeSpecificsToValue);
+  SET_EXTENSION(typed_url, TypedUrlSpecificsToValue);
   return value;
 }
 
 #undef SET
 #undef SET_REP
 
 #undef SET_BOOL
 #undef SET_BYTES
 #undef SET_INT32
 #undef SET_INT64
 #undef SET_INT64_REP
 #undef SET_STR
 #undef SET_STR_REP
 
 #undef SET_EXTENSION
 
 }  // namespace browser_sync