Issue 9460022: HANDLE_EINTR: parenthesize arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9460022: HANDLE_EINTR: parenthesize arguments (Closed)

Created:
8 years, 10 months ago by vapier

Modified:
8 years, 9 months ago

Reviewers:
Mark Mentovai, darin (slow to review), brettw, Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org, agl

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

HANDLE_EINTR: parenthesize arguments Make sure the expanded arg is in a paren to guard against possible side effects. BUG=chromium:115686 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127721

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/eintr_wrapper.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

Mark Mentovai

LGTM Although I’d be surprised if this made a difference anywhere, considering the way we ...

8 years, 9 months ago (2012-03-16 17:52:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/9460022/1

8 years, 9 months ago (2012-03-19 19:42:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/9460022/1

8 years, 9 months ago (2012-03-19 23:04:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/9460022/7004

8 years, 9 months ago (2012-03-20 15:45:23 UTC) #5

Change committed as 127721