chrome_frame/test/chrome_frame_test_utils.cc - Issue 9460019: Reduce flakiness in chrome_frame_tests.exe by having each run in a clean environment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/chrome_frame_test_utils.cc

Issue 9460019: Reduce flakiness in chrome_frame_tests.exe by having each run in a clean environment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed robert's comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome_frame/test/automation_client_mock.cc ('K') | « chrome_frame/test/chrome_frame_test_utils.h ('k') | chrome_frame/test/proxy_factory_mock.cc » ('j') | chrome_frame/test/test_scrubber.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome_frame/test/chrome_frame_test_utils.cc

diff --git a/chrome_frame/test/chrome_frame_test_utils.cc b/chrome_frame/test/chrome_frame_test_utils.cc

index 3ce58246372310a5ed59f4a08d14d047c9e5f77b..1b8bbf387c4b107e2c5df5a6bd95849b5ee120eb 100644

--- a/chrome_frame/test/chrome_frame_test_utils.cc

+++ b/chrome_frame/test/chrome_frame_test_utils.cc

@@ -177,13 +177,16 @@ base::ProcessHandle LaunchExecutable(const std::wstring& executable,

return process;

}

-base::ProcessHandle LaunchChrome(const std::wstring& url) {

+base::ProcessHandle LaunchChrome(const std::wstring& url,

+ const FilePath& user_data_dir) {

FilePath path;

PathService::Get(base::DIR_MODULE, &path);

path = path.AppendASCII(kChromeImageName);

CommandLine cmd(path);

cmd.AppendSwitch(switches::kNoFirstRun);

+ if (!user_data_dir.empty())

+ cmd.AppendSwitchPath(switches::kUserDataDir, user_data_dir);

cmd.AppendArgNative(url);

base::ProcessHandle process = NULL;