Reduce flakiness in chrome_frame_tests.exe by having each run in a clean environment.

chrome_frame/test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test_utils.h"
 
 #include <atlbase.h>
 #include <atlwin.h>
 #include <shellapi.h>
 #include <winternl.h>
@@ skipping 229 matching lines @@
 ScopedChromeFrameRegistrar::~ScopedChromeFrameRegistrar() {
   if (FilePath(original_dll_path_) != FilePath(new_chrome_frame_dll_path_)) {
     RegisterChromeFrameAtPath(original_dll_path_);
   } else if (registration_type_ == PER_USER) {
     UnregisterAtPath(new_chrome_frame_dll_path_, registration_type_);
     HWND chrome_frame_helper_window =
         FindWindow(L"ChromeFrameHelperWindowClass", NULL);
     if (IsWindow(chrome_frame_helper_window)) {
       PostMessage(chrome_frame_helper_window, WM_CLOSE, 0, 0);
     } else {
-      chrome_frame_test::KillProcesses(L"chrome_frame_helper.exe", 0, false);
+      base::KillProcesses(L"chrome_frame_helper.exe", 0, NULL);
     }
   }
 }
 
 void ScopedChromeFrameRegistrar::RegisterChromeFrameAtPath(
     const std::wstring& path) {
   RegisterAtPath(path, registration_type_);
   new_chrome_frame_dll_path_ = path;
 }
 
@@ skipping 142 matching lines @@
   }
 
  protected:
   std::wstring argument_to_find_;
 };
 
 }  // namespace
 
 bool KillAllNamedProcessesWithArgument(const std::wstring& process_name,
                                        const std::wstring& argument) {
-  bool result = true;
-  ArgumentFilter filter(argument);
-  base::NamedProcessIterator iter(process_name, &filter);
-  while (const base::ProcessEntry* entry = iter.NextProcessEntry()) {
-    if (!base::KillProcessById(entry->pid(), 0, true)) {
-      result = false;
-    }
-  }
-
-  return result;
+  return base::KillProcesses(process_name, 0, &ArgumentFilter(argument));
 }
 
 bool IsWorkstationLocked() {
   bool is_locked = true;
   HDESK input_desk = ::OpenInputDesktop(0, 0, GENERIC_READ);
   if (input_desk)  {
     wchar_t name[256] = {0};
     DWORD needed = 0;
     if (::GetUserObjectInformation(input_desk,
       UOI_NAME,
       name,
       sizeof(name),
       &needed)) {
         is_locked = lstrcmpi(name, L"default") != 0;
     }
     ::CloseDesktop(input_desk);
   }
   return is_locked;
 }