chrome/renderer/extensions/app_bindings.h - Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_bindings.h

Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: koz comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_api.h ('K') | « chrome/common/extensions/extension_permission_set.cc ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | chrome/renderer/extensions/chrome_v8_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/app_bindings.h

diff --git a/chrome/renderer/extensions/app_bindings.h b/chrome/renderer/extensions/app_bindings.h

index 9455ba2a9fc2c1a33e662efdffcef519b51a8728..4f0960d7e0f50a41c114f612a96a0200180ecd96 100644

--- a/chrome/renderer/extensions/app_bindings.h

+++ b/chrome/renderer/extensions/app_bindings.h

@@ -22,7 +22,10 @@ class ChromeV8Context;

// TODO(aa): Add unit testing for this class.

class AppBindings : public ChromeV8Extension {

public:

- explicit AppBindings(ExtensionDispatcher* dispatcher);

+ AppBindings(

+ int dependency_count,

Aaron Boodman 2012/02/27 23:32:31 I think that you can combine this line with the on

not at google - send to devlin 2012/02/28 05:00:04 Done. Oh... this will all be deleted after koz's

+ const char** dependencies,

+ ExtensionDispatcher* dispatcher);

protected:

virtual ChromeV8ExtensionHandler* CreateHandler(