Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

chrome/browser/renderer_host/chrome_render_view_host_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 77 matching lines @@
 }
 
 void ChromeRenderViewHostObserver::InitRenderViewForExtensions() {
   const Extension* extension = GetExtension();
   if (!extension)
     return;
 
   content::RenderProcessHost* process = render_view_host()->process();
 
   if (extension->is_app()) {
-    Send(new ExtensionMsg_ActivateApplication(extension->id()));
     // Though we already record the associated process ID for the renderer in
     // InitRenderViewHostForExtensions, the process might have crashed and been
     // restarted (hence the re-initialization), so we need to update that
     // mapping.
     profile_->GetExtensionService()->SetInstalledAppForRenderer(
         process->GetID(), extension);
   }
 
   // Some extensions use chrome:// URLs.
   Extension::Type type = extension->GetType();
   if (type == Extension::TYPE_EXTENSION ||
       type == Extension::TYPE_PACKAGED_APP) {
     ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
         process->GetID(), chrome::kChromeUIScheme);
 
     if (profile_->GetExtensionService()->extension_prefs()->AllowFileAccess(
           extension->id())) {
       ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
           process->GetID(), chrome::kFileScheme);
     }
   }
 
-  if (type == Extension::TYPE_EXTENSION ||
-      type == Extension::TYPE_USER_SCRIPT ||
-      type == Extension::TYPE_PACKAGED_APP ||
-      type == Extension::TYPE_PLATFORM_APP ||
-      (type == Extension::TYPE_HOSTED_APP &&
-       extension->location() == Extension::COMPONENT)) {
+  if (type != Extension::TYPE_THEME)

[Aaron Boodman, 2012/03/06 01:17:21]

I prefer a whitelist here to the blacklist.

I guess it would be even better to do it with a switch and for the default case
CHECK(false) so we don't forget to update this.

[not at google - send to devlin, 2012/03/06 03:53:00]

Done.

(added NOTREACHED() to a version of the patch that i'll upload next round of
comments... though clang will actually check this I believe).

     Send(new ExtensionMsg_ActivateExtension(extension->id()));
-  }
 }
 
 const Extension* ChromeRenderViewHostObserver::GetExtension() {
   // Note that due to ChromeContentBrowserClient::GetEffectiveURL(), hosted apps
   // (excluding bookmark apps) will have a chrome-extension:// URL for their
   // site, so we can ignore that wrinkle here.
   SiteInstance* site_instance = render_view_host()->site_instance();
   const GURL& site = site_instance->GetSite();
 
   if (!site.SchemeIs(chrome::kExtensionScheme))
@@ skipping 22 matching lines @@
   if (process_manager)
     process_manager->UnregisterRenderViewHost(rvh);
 }
 
 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED,
       content::Source<RenderViewHost>(render_view_host()),
       content::NotificationService::NoDetails());
 }