chrome/common/extensions/api/tabs.json - Issue 9456037: Adding run_at to chrome.tabs.executeScript/insertCss.

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 9456037: Adding run_at to chrome.tabs.executeScript/insertCss. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/common/extensions/docs/tabs.html » ('j') | chrome/test/data/extensions/api_test/executescript/run_at/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/tabs.json

diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json

index de8ed6724f6afa847d699e8f4a8ee23fe349a0ca..756ee1c19aabfe7e162e3d84054fa0ff533393ba 100644

--- a/chrome/common/extensions/api/tabs.json

+++ b/chrome/common/extensions/api/tabs.json

@@ -576,7 +576,13 @@

"properties": {

"code": {"type": "string", "optional": true, "description": "JavaScript code to execute."},

"file": {"type": "string", "optional": true, "description": "JavaScript file to execute."},

- "allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is true, this function injects script into all frames of current page. By default, it's false and script is injected only into the top main frame."}

+ "allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is true, this function injects script into all frames of current page. By default, it's false and script is injected only into the top main frame."},

+ "runAt": {

+ "type": "string",

+ "optional": true,

+ "enum": ["document_start", "document_end", "document_idle"],

+ "descrption": "The soonest that the script will be injected into the tab. Defaults to \"document_idle\"."

+ }

}

{

@@ -601,7 +607,13 @@

"properties": {

"code": {"type": "string", "optional": true, "description": "CSS code to be injected."},

"file": {"type": "string", "optional": true, "description": "CSS file to be injected."},

- "allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is true, this function injects CSS text into all frames of current page. By default, it's false and CSS is injected only into the top main frame."}

+ "allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is true, this function injects CSS text into all frames of current page. By default, it's false and CSS is injected only into the top main frame."},

+ "runAt": {

+ "type": "string",

+ "optional": true,

+ "enum": ["document_start", "document_end", "document_idle"],

+ "descrption": "The soonest that the CSS will be injected into the tab. Defaults to \"document_idle\"."

Aaron Boodman 2012/03/28 01:04:16 I think CSS is always injected immediately, so thi

eaugusti 2012/03/28 17:40:19 I took a closer look, and CSS is not injected imme

Aaron Boodman 2012/03/30 21:47:04 That is weird, but OK.

+ }

}

{