Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: base/stack_container_unittest.cc

Issue 9456032: Make StackContainer test pass on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: include path Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/stack_container.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/stack_container.h" 5 #include "base/stack_container.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/memory/aligned_memory.h" 9 #include "base/memory/aligned_memory.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 TEST(StackContainer, BufferAlignment) { 115 TEST(StackContainer, BufferAlignment) {
116 StackVector<wchar_t, 16> text; 116 StackVector<wchar_t, 16> text;
117 text->push_back(L'A'); 117 text->push_back(L'A');
118 EXPECT_ALIGNED(&text[0], ALIGNOF(wchar_t)); 118 EXPECT_ALIGNED(&text[0], ALIGNOF(wchar_t));
119 119
120 StackVector<double, 1> doubles; 120 StackVector<double, 1> doubles;
121 doubles->push_back(0.0); 121 doubles->push_back(0.0);
122 EXPECT_ALIGNED(&doubles[0], ALIGNOF(double)); 122 EXPECT_ALIGNED(&doubles[0], ALIGNOF(double));
123 123
124 StackVector<AlignedData<16>, 1> aligned16;
125 aligned16->push_back(AlignedData<16>());
126 EXPECT_ALIGNED(&aligned16[0], 16);
127
128 #if !defined(OS_ANDROID)
129 // It seems that android doesn't respect greater than 16 byte alignment for
130 // non-POD data on the stack, even though ALIGNOF(aligned256) == 256.
124 StackVector<AlignedData<256>, 1> aligned256; 131 StackVector<AlignedData<256>, 1> aligned256;
125 aligned256->push_back(AlignedData<256>()); 132 aligned256->push_back(AlignedData<256>());
126 EXPECT_ALIGNED(&aligned256[0], 256); 133 EXPECT_ALIGNED(&aligned256[0], 256);
134 #endif
127 } 135 }
128 136
129 #ifdef COMPILER_MSVC 137 #ifdef COMPILER_MSVC
130 // Make sure all the class compiles correctly. 138 // Make sure all the class compiles correctly.
131 // TODO(pinkerton): i'm not sure why this doesn't compile on GCC, but 139 // TODO(pinkerton): i'm not sure why this doesn't compile on GCC, but
132 // it doesn't. 140 // it doesn't.
133 template StackVector<int, 2>; 141 template StackVector<int, 2>;
134 template StackVector<scoped_refptr<Dummy>, 2>; 142 template StackVector<scoped_refptr<Dummy>, 2>;
135 #endif 143 #endif
OLDNEW
« no previous file with comments | « base/stack_container.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698