Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3247)

Unified Diff: chrome/browser/sync/sync_ui_util.cc

Issue 9456031: Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_ui_util.h ('k') | chrome/browser/sync/sync_ui_util_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_ui_util.cc
diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc
index 928a4f301748b32e3ab875122d2b4ee25b8e3fc3..f1ff6ae533b1f36dbef42017b4bedc43fde299c6 100644
--- a/chrome/browser/sync/sync_ui_util.cc
+++ b/chrome/browser/sync/sync_ui_util.cc
@@ -19,6 +19,8 @@
#include "chrome/browser/sync/sessions/session_state.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/net/gaia/google_service_auth_error.h"
@@ -449,30 +451,6 @@ string16 GetSyncMenuLabel(ProfileSyncService* service) {
return l10n_util::GetStringUTF16(IDS_SYNC_START_SYNC_BUTTON_LABEL);
}
-void OpenSyncMyBookmarksDialog(Profile* profile,
- Browser* browser,
- ProfileSyncService::SyncEventCodes code) {
- ProfileSyncService* service =
- ProfileSyncServiceFactory::GetInstance()->GetForProfile(
- profile->GetOriginalProfile());
- if (!service || !service->IsSyncEnabled()) {
- LOG(DFATAL) << "OpenSyncMyBookmarksDialog called with sync disabled";
- return;
- }
-
- if (service->HasSyncSetupCompleted()) {
- bool create_window = browser == NULL;
- if (create_window)
- browser = Browser::Create(profile);
- browser->ShowOptionsTab(chrome::kPersonalOptionsSubPage);
- if (create_window)
- browser->window()->Show();
- } else {
- service->ShowLoginDialog();
- ProfileSyncService::SyncEvent(code); // UMA stats
- }
-}
-
void AddBoolSyncDetail(ListValue* details,
const std::string& stat_name,
bool stat_value) {
« no previous file with comments | « chrome/browser/sync/sync_ui_util.h ('k') | chrome/browser/sync/sync_ui_util_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698