Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8213)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 9456031: Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.h ('k') | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index 64163aae6658e896b1df22f615b6bae982117b84..7e8dd1b1503f601c0f1a1ff81f0b0f30c4ecad65 100755
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -973,12 +973,6 @@ void ProfileSyncService::OnActionableError(const SyncProtocolError& error) {
NotifyObservers();
}
-void ProfileSyncService::ShowLoginDialog() {
- // TODO(atwilson): Remove this API and have the callers directly call
- // LoginUIService.
- LoginUIServiceFactory::GetForProfile(profile_)->ShowLoginUI();
-}
-
void ProfileSyncService::ShowErrorUI() {
if (WizardIsVisible()) {
wizard_.Focus();
@@ -992,7 +986,7 @@ void ProfileSyncService::ShowErrorUI() {
// Any other errors (such as unrecoverable error) should be handled by the UI
// itself and should not result in a call to ShowErrorUI.
if (last_auth_error_.state() != AuthError::NONE) {
- ShowLoginDialog();
+ LoginUIServiceFactory::GetForProfile(profile_)->ShowLoginUI();
} else if (ShouldShowActionOnUI(last_actionable_error_)) {
ShowSyncSetup(chrome::kPersonalOptionsSubPage);
} else {
« no previous file with comments | « chrome/browser/sync/profile_sync_service.h ('k') | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698