Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 9456031: Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <numeric> 8 #include <numeric>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1028 matching lines...) Expand 10 before | Expand all | Expand 10 after
1039 case IDC_PRESENTATION_MODE: { 1039 case IDC_PRESENTATION_MODE: {
1040 enable &= [self supportsFullscreen]; 1040 enable &= [self supportsFullscreen];
1041 if ([static_cast<NSObject*>(item) isKindOfClass:[NSMenuItem class]]) { 1041 if ([static_cast<NSObject*>(item) isKindOfClass:[NSMenuItem class]]) {
1042 NSString* menuTitle = l10n_util::GetNSString( 1042 NSString* menuTitle = l10n_util::GetNSString(
1043 [self inPresentationMode] ? IDS_EXIT_PRESENTATION_MAC : 1043 [self inPresentationMode] ? IDS_EXIT_PRESENTATION_MAC :
1044 IDS_ENTER_PRESENTATION_MAC); 1044 IDS_ENTER_PRESENTATION_MAC);
1045 [static_cast<NSMenuItem*>(item) setTitle:menuTitle]; 1045 [static_cast<NSMenuItem*>(item) setTitle:menuTitle];
1046 } 1046 }
1047 break; 1047 break;
1048 } 1048 }
1049 case IDC_SYNC_BOOKMARKS: { 1049 case IDC_SHOW_SYNC_SETUP: {
1050 Profile* original_profile = 1050 Profile* original_profile =
1051 browser_->profile()->GetOriginalProfile(); 1051 browser_->profile()->GetOriginalProfile();
1052 enable &= original_profile->IsSyncAccessible(); 1052 enable &= original_profile->IsSyncAccessible();
1053 sync_ui_util::UpdateSyncItem(item, enable, original_profile); 1053 sync_ui_util::UpdateSyncItem(item, enable, original_profile);
1054 break; 1054 break;
1055 } 1055 }
1056 default: 1056 default:
1057 // Special handling for the contents of the Text Encoding submenu. On 1057 // Special handling for the contents of the Text Encoding submenu. On
1058 // Mac OS, instead of enabling/disabling the top-level menu item, we 1058 // Mac OS, instead of enabling/disabling the top-level menu item, we
1059 // enable/disable the submenu's contents (per Apple's HIG). 1059 // enable/disable the submenu's contents (per Apple's HIG).
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
2167 2167
2168 - (BOOL)supportsBookmarkBar { 2168 - (BOOL)supportsBookmarkBar {
2169 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR]; 2169 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
2170 } 2170 }
2171 2171
2172 - (BOOL)isTabbedWindow { 2172 - (BOOL)isTabbedWindow {
2173 return browser_->is_type_tabbed(); 2173 return browser_->is_type_tabbed();
2174 } 2174 }
2175 2175
2176 @end // @implementation BrowserWindowController(WindowType) 2176 @end // @implementation BrowserWindowController(WindowType)
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698