Add wider support to json_schema_compiler

tools/json_schema_compiler/util.h

Index: tools/json_schema_compiler/util.h
diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h
index 707c626714a3d90ce1efe38f1c2a7e46d3a0ce2a..f71c93cb9f8a138f9ad274771bd7ab8f0cbd6648 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -150,30 +150,22 @@ void PopulateListFromOptionalArray(
 
 }
 
-// Sets |out|.|name| to a newly created ListValue containing |from|. Requires
-// GetItemFromList to be implemented for |T|.
 template <class T>
-void PopulateDictionaryFromArray(
-    const std::vector<T>& from,
-    const std::string& name,
-    base::DictionaryValue* out) {
+scoped_ptr<Value> CreateValueFromArray(
+    const std::vector<T>& from) {
   base::ListValue* list = new base::ListValue();
-  out->SetWithoutPathExpansion(name, list);
   PopulateListFromArray(from, list);
+  return scoped_ptr<Value>(list);

[not at google - send to devlin, 2012/02/24 03:53:05]

TBH a more idomatic way of writing this method would be

scoped_ptr<base::ListValue> list(new base::ListValue());
PopulateListFromArray(from, list.get());
return list.Pass();

[calamity, 2012/02/24 15:10:40]

Hmm, I tried this to start, got this error:

/tools/json_schema_compiler/util.h:158:3: error: no viable constructor returning
object of type 'scoped_ptr<base::Value>'
  return list.Pass();
  ^      ~~~~~~~~~~~
./base/memory/scoped_ptr.h:113:29: note: candidate constructor not viable: no
known conversion from 'scoped_ptr<base::Value>' to 'scoped_ptr<base::Value> &'
for 1st argument;
  MOVE_ONLY_TYPE_FOR_CPP_03(scoped_ptr, RValue)
                            ^
./base/move.h:204:3: note: expanded from macro 'MOVE_ONLY_TYPE_FOR_CPP_03'
  type(type&); \
  ^

 }
 
-// If |from| is non-NULL, sets |out|.|name| to a newly created ListValue
-// containing |from|. Requires GetItemFromList to be implemented for |T|.
 template <class T>
-void PopulateDictionaryFromOptionalArray(
-    const scoped_ptr<std::vector<T> >& from,
-    const std::string& name,
-    base::DictionaryValue* out) {
+scoped_ptr<Value> CreateValueFromOptionalArray(
+    const scoped_ptr<std::vector<T> >& from) {
   if (from.get())
-    PopulateDictionaryFromArray(*from, name, out);
+    return CreateValueFromArray(*from);
+  return scoped_ptr<Value>();
 }
 
-
 }  // namespace api_util
 }  // namespace extensions