src/x64/disasm-x64.cc - Issue 9455088: Remove static initializers in v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/disasm-x64.cc

Issue 9455088: Remove static initializers in v8. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address Florian and Sven comments. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/disasm-x64.cc

diff --git a/src/x64/disasm-x64.cc b/src/x64/disasm-x64.cc

index 5cbdad7ac3f638e7e71eb823f73fbb9e37d25c59..adeda0bb08b293378791710509874694bdf3633f 100644

--- a/src/x64/disasm-x64.cc

+++ b/src/x64/disasm-x64.cc

@@ -34,6 +34,7 @@

#if defined(V8_TARGET_ARCH_X64)

#include "disasm.h"

+#include "lazy-instance.h"

namespace disasm {

@@ -269,7 +270,8 @@ void InstructionTable::AddJumpConditionalShort() {

}

-static InstructionTable instruction_table;

+static v8::internal::LazyInstance<InstructionTable>::type instruction_table =

+ LAZY_INSTANCE_INITIALIZER;

static InstructionDesc cmov_instructions[16] = {

@@ -1338,7 +1340,7 @@ int DisassemblerX64::InstructionDecode(v8::internal::Vector<char> out_buffer,

data++;

}

- const InstructionDesc& idesc = instruction_table.Get(current);

+ const InstructionDesc& idesc = instruction_table.Get().Get(current);

byte_size_operand_ = idesc.byte_size_operation;

switch (idesc.type) {

case ZERO_OPERANDS_INSTR: