Issue 9455086: Make WeakPtr::operator* return reference instead of pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9455086: Make WeakPtr::operator* return reference instead of pointer (Closed)

Created:
8 years, 10 months ago by hashimoto

Modified:
8 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make WeakPtr::operator* return reference instead of pointer Reference is more suitable type for operator*'s return values. Add test code for operator->. BUG=None TEST=base_unittests --gtest_filter="WeakPtrTest.Dereference" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124141

Patch Set 1 : _ #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	base/memory/weak_ptr.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	base/memory/weak_ptr_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM (not sure why i didn't see this before!)

8 years, 9 months ago (2012-02-28 21:18:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9455086/6001

8 years, 9 months ago (2012-02-29 03:33:58 UTC) #3

Change committed as 124141

Expand Messages | Collapse Messages