Chromium Code Reviews| Index: third_party/libjingle/overrides/talk/base/thread.cc |
| =================================================================== |
| --- third_party/libjingle/overrides/talk/base/thread.cc (revision 123769) |
| +++ third_party/libjingle/overrides/talk/base/thread.cc (working copy) |
| @@ -85,7 +85,6 @@ |
| #ifdef WIN32 |
| ThreadManager::ThreadManager() { |
| key_ = TlsAlloc(); |
| - WrapCurrentThread(); |
| } |
| ThreadManager::~ThreadManager() { |
| @@ -126,16 +125,25 @@ |
| Runnable* runnable; |
| }; |
| +Thread::Thread() |
| + : MessageQueue() { |
|
tommi (sloooow) - chröme
2012/02/28 21:32:18
any need to explicitly call MessageQueue()?
Ronghua Wu (Left Chromium)
2012/02/28 23:16:57
no.
|
| + Construct(); |
| +} |
| + |
| Thread::Thread(SocketServer* ss) |
| - : MessageQueue(ss), |
| - priority_(PRIORITY_NORMAL), |
| - started_(false), |
| - has_sends_(false), |
| + : MessageQueue(ss) { |
| + Construct(); |
| +} |
| + |
| +void Thread::Construct() { |
|
tommi (sloooow) - chröme
2012/02/28 21:32:18
same comment for Construct() here as for the other
Ronghua Wu (Left Chromium)
2012/02/28 23:16:57
But how do we insure we call the correct base clas
tommi (sloooow) - chröme
2012/02/29 09:54:22
ah, I missed that. In this case I guess the Const
|
| + priority_ = PRIORITY_NORMAL; |
| + started_ = false; |
| + has_sends_ = false; |
| #if defined(WIN32) |
| - thread_(NULL), |
| + thread_ = NULL; |
| #endif |
| - owned_(true), |
| - delete_self_when_complete_(false) { |
| + owned_ = true; |
| + delete_self_when_complete_ = false; |
| SetName("Thread", this); // default name |
| } |