Issue 9455062: Add gfx::Image::Image(const SkBitmap&) constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9455062: Add gfx::Image::Image(const SkBitmap&) constructor. (Closed)

Created:
8 years, 10 months ago by Robert Sesek

Modified:
8 years, 9 months ago

Reviewers:
Mark Mentovai, Ben Goodger (Google)

CC:
chromium-reviews, sail, jstritar

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add gfx::Image::Image(const SkBitmap&) constructor. This helps avoid the pattern |new gfx::Image(new SkBitmap(some_stack_skbitmap))|. BUG=none TEST=ui_unittests --gtest_filter=ImageTest.SkiaRefToSkia Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123539

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -0 lines)			Patch
M	ui/gfx/image/image.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/gfx/image/image.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/gfx/image/image_unittest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9455062/1

8 years, 10 months ago (2012-02-24 19:02:04 UTC) #3

lgtm

Expand Messages | Collapse Messages