Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: net/socket/socket_test_util.cc

Issue 9454025: Set SSLInfo.client_cert_sent when origin bound cert was sent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_mac.cc » ('j') | net/socket/ssl_client_socket_nss.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index c48694d60d5a3622b6a61af05cc32dec42eb8890..96b137f20fdda5245488a82a7e63a1d6f14d8a97 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -1132,7 +1132,8 @@ base::TimeDelta MockSSLClientSocket::GetConnectTimeMicros() const {
void MockSSLClientSocket::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->Reset();
ssl_info->cert = data_->cert;
- ssl_info->client_cert_sent = data_->client_cert_sent;
+ ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
+ data_->client_cert_sent;
wtc 2012/02/24 00:56:57 I believe this change is unnecessary/wrong for the
mattm 2012/02/24 03:09:58 hmm, well that would mean tests would need to reme
wtc 2012/02/24 04:23:35 I didn't look at the unit tests, so I don't know t
}
void MockSSLClientSocket::GetSSLCertRequestInfo(
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_mac.cc » ('j') | net/socket/ssl_client_socket_nss.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698