Set SSLInfo.client_cert_sent when origin bound cert was sent.

Set SSLInfo.client_cert_sent when origin bound cert was sent.

BUG=115376
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123620

[mattm, 2012-02-24 00:44:23]

wtc: please review
rch: fyi

[wtc, 2012-02-24 00:56:57]

Patch Set 1 LGTM.  Please note my first comment below.

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc#...
net/socket/socket_test_util.cc:1136: data_->client_cert_sent;

I believe this change is unnecessary/wrong for the
MockSSLClientSocket class, because data_->client_cert_sent
directly mocks the client_cert_sent value.

http://codereview.chromium.org/9454025/diff/1/net/socket/ssl_client_socket_ns...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/9454025/diff/1/net/socket/ssl_client_socket_ns...
net/socket/ssl_client_socket_nss.cc:502: ssl_info->client_cert_sent =
WasOriginBoundCertSent() ||

Another solution is to set ssl_config_.send_client_cert to
true and set ssl_config_.client_cert to the origin-bound
cert.  But that will require converting the NSS CERTCertificate
to a Chrome X509Certificate object, so it can be stored
in ssl_config_.client_cert, and that extra reference will
keep the certificate bytes in memory longer.

[mattm, 2012-02-24 03:09:57]

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc#...
net/socket/socket_test_util.cc:1136: data_->client_cert_sent;
On 2012/02/24 00:56:57, wtc wrote:
> 
> I believe this change is unnecessary/wrong for the
> MockSSLClientSocket class, because data_->client_cert_sent
> directly mocks the client_cert_sent value.

hmm, well that would mean tests would need to remember to also set
client_cert_sent when they set data.origin_bound_cert_type.  It looks like they
currently don't, though I could remove this and update the tests instead.

[wtc, 2012-02-24 04:23:35]

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/9454025/diff/1/net/socket/socket_test_util.cc#...
net/socket/socket_test_util.cc:1136: data_->client_cert_sent;
On 2012/02/24 03:09:58, mattm wrote:
>
> hmm, well that would mean tests would need to remember to also set
> client_cert_sent when they set data.origin_bound_cert_type.  It looks like
they
> currently don't, though I could remove this and update the tests instead.

I didn't look at the unit tests, so I don't know the issues
you mentioned.  Let's go over the code together tomorrow.

[commit-bot: I haz the power, 2012-02-24 23:32:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/9454025/1

[commit-bot: I haz the power, 2012-02-25 01:28:47]

Change committed as 123620