Support named parameters for super initializers and redirections.

frog/leg/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
 }
 
 class TreeElementMapping implements TreeElements {
@@ skipping 351 matching lines @@
       // Check that there are no other initializers.
       if (!initializers.tail.isEmpty()) {
         error(call, MessageKind.REDIRECTING_CONSTRUCTOR_HAS_INITIALIZER);
       }
     } else {
       visitor.error(call, MessageKind.CONSTRUCTOR_CALL_EXPECTED);
       validTarget = false;
     }
 
     if (validTarget) {
+      // Resolve the arguments of the call to get a selector.

[ngeoffray, 2012/02/24 13:43:01]

This is not just for getting a selector, but also resolving the arguments. Maybe
improve the comment by saying:
// Resolve the arguments, and make sure the call gets a selector, by calling
handleArguments.

+      visitor.inStaticContext( () => visitor.handleArguments(call) );
+      // Lookup constructor and try to match it to the selector.
       ResolverTask resolver = visitor.compiler.resolver;
       result = resolver.lookupConstructor(lookupTarget, call);
       if (result === null) {
         SourceString constructorName = resolver.getConstructorName(call);
         SourceString className = lookupTarget.name;
         String name = (constructorName === const SourceString(''))
                           ? className.stringValue
                           : "$className.$constructorName";
         error(call, MessageKind.CANNOT_RESOLVE_CONSTRUCTOR, [name]);
       } else {
         final Compiler compiler = visitor.compiler;
+        Selector selector = visitor.mapping.getSelector(call);
         // TODO(karlklose): support optional arguments.
-        if (result.parameterCount(compiler) != call.argumentCount()) {
+        if (!selector.applies(compiler, result)) {
           error(call, MessageKind.NO_MATCHING_CONSTRUCTOR);
         }
       }
       visitor.useElement(call, result);
     }
-    // Resolve the arguments of the call.
-    for (Link<Node> arguments = call.arguments;
-         !arguments.isEmpty();
-         arguments = arguments.tail) {
-      visitor.visitInStaticContext(arguments.head);
-    }
     return result;
   }
 
   FunctionElement resolveRedirection(FunctionElement constructor,
                                      FunctionExpression functionNode) {
     if (functionNode.initializers === null) return null;
     Link<Node> link = functionNode.initializers.nodes;
     if (!link.isEmpty() && Initializers.isConstructorRedirect(link.head)) {
       return resolveSuperOrThis(constructor, functionNode, link.head);
     }
@@ skipping 142 matching lines @@
       super(compiler);
 
   Element lookup(Node node, SourceString name) {
     Element result = context.lookup(name);
     if (!inInstanceContext && result != null && result.isInstanceMember()) {
       error(node, MessageKind.NO_INSTANCE_AVAILABLE, [node]);
     }
     return result;
   }
 
-  visitInStaticContext(Node node) {
+  inStaticContext(action()) {
     bool wasInstanceContext = inInstanceContext;
     inInstanceContext = false;
-    visit(node);
+    action();
     inInstanceContext = wasInstanceContext;
   }
 
+  visitInStaticContext(Node node) {
+    inStaticContext(() => visit(node));
+  }
+
   visitIdentifier(Identifier node) {
     if (node.isThis()) {
       if (!inInstanceContext) {
         error(node, MessageKind.NO_INSTANCE_AVAILABLE, [node]);
       }
       return null;
     } else if (node.isSuper()) {
       if (!inInstanceContext) error(node, MessageKind.NO_SUPER_IN_STATIC);
       return null;
     } else {
@@ skipping 857 matching lines @@
 class TopScope extends Scope {
   LibraryElement get library() => element;
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) => library.find(name);
 
   Element add(Element element) {
     throw "Cannot add an element in the top scope";
   }
 }