Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 9453005: Set platform app window size on Mac (Closed)

Created:
8 years, 10 months ago by sail
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Set platform app window size on Mac This is a copy of the views CL that sets the initial and minimum window size of shell windows. BUG=112651 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124572

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 2 chunks +7 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
sail
8 years, 10 months ago (2012-02-23 06:32:42 UTC) #1
jeremy
https://chromiumcodereview.appspot.com/9453005/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right): https://chromiumcodereview.appspot.com/9453005/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm#newcode27 chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:27: rect.size.height = host_->extension()->launch_height(); What if the launch_width is larger ...
8 years, 10 months ago (2012-02-23 13:21:40 UTC) #2
sail
https://chromiumcodereview.appspot.com/9453005/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right): https://chromiumcodereview.appspot.com/9453005/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm#newcode27 chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:27: rect.size.height = host_->extension()->launch_height(); On 2012/02/23 13:21:40, jeremy wrote: > ...
8 years, 10 months ago (2012-02-23 19:42:34 UTC) #3
jeremy
lgtm
8 years, 10 months ago (2012-02-23 19:51:03 UTC) #4
Mihai Parparita -not on Chrome
LGTM
8 years, 10 months ago (2012-02-24 02:01:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9453005/1
8 years, 9 months ago (2012-03-01 22:28:42 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 02:29:00 UTC) #7
Change committed as 124572

Powered by Google App Engine
This is Rietveld 408576698