Implement File.{readAsBytes, readAsText, readAsLines}.

tests/standalone/src/FileTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing file I/O.
 
 #import("dart:io");
 
 class MyListOfOneElement implements List {
   int _value;
@@ skipping 862 matching lines @@
   static void testOpenDirectoryAsFileSync() {
     var f = new File('.');
     try {
       f.openSync();
       Expect.fail("Expected exception opening directory as file");
     } catch (var e) {
       Expect.isTrue(e is FileIOException);
     }
   }
 
+  static void testReadAsBytes() {
+    var port = new ReceivePort.singleShot();
+    port.receive((result, replyTo) {
+      Expect.equals(42, result);
+    });
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var f = new File(name);
+    f.readAsBytes();
+    f.readAsBytesHandler = (bytes) {
+      Expect.isTrue(new String.fromCharCodes(bytes).endsWith("42 bytes."));
+      port.toSendPort().send(bytes.length);
+    };
+    f.errorHandler = (e) {
+      Expect.fail("No errors expected: $e");
+    };
+  }
+
+  static void testReadAsBytesSync() {
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var bytes = new File(name).readAsBytesSync();
+    Expect.isTrue(new String.fromCharCodes(bytes).endsWith("42 bytes."));
+    Expect.equals(bytes.length, 42);
+  }
+
+  static void testReadAsText() {

[Søren Gjesse, 2012/02/24 07:24:51]

I know that the decoders are tested elsewhere, but maybe we should add a test
file with some non-ascii text and test reading that as both UTF-8 and ISO-8859-1
and observe the difference.

[Mads Ager (google), 2012/02/24 13:11:17]

Done.

+    var port = new ReceivePort.singleShot();
+    port.receive((result, replyTo) {
+      Expect.equals(42, result);
+    });
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var f = new File(name);
+    f.readAsText('UTF-8');
+    f.readAsTextHandler = (text) {
+      Expect.isTrue(text.endsWith("42 bytes."));
+      port.toSendPort().send(text.length);
+    };
+    f.errorHandler = (e) {
+      Expect.fail("No errors expected: $e");
+    };
+  }
+
+  static void testReadAsTextSync() {
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var text = new File(name).readAsTextSync();
+    Expect.isTrue(text.endsWith("42 bytes."));
+    Expect.equals(42, text.length);
+  }
+
+  static void testReadAsLines() {

[Søren Gjesse, 2012/02/24 07:24:51]

Again I know that the line-splitting is tested elsewhere, but maybe we should
have a multiline test text file

[Mads Ager (google), 2012/02/24 13:11:17]

Done.

+    var port = new ReceivePort.singleShot();
+    port.receive((result, replyTo) {
+      Expect.equals(42, result);
+    });
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var f = new File(name);
+    f.readAsLines('UTF-8');
+    f.readAsLinesHandler = (lines) {
+      Expect.equals(1, lines.length);
+      var line = lines[0];
+      Expect.isTrue(line.endsWith("42 bytes."));
+      port.toSendPort().send(line.length);
+    };
+    f.errorHandler = (e) {
+      Expect.fail("No errors expected: $e");
+    };
+  }
+
+  static void testReadAsLinesSync() {
+    var name = getFilename("tests/vm/data/fixed_length_file");
+    var lines = new File(name).readAsLinesSync();
+    Expect.equals(1, lines.length);
+    var line = lines[0];
+    Expect.isTrue(line.endsWith("42 bytes."));
+    Expect.equals(42, line.length);
+  }
+
+  static void testReadAsErrors() {
+    var f = new File('.');
+    Expect.throws(f.readAsBytesSync, (e) => e is FileIOException);
+    Expect.throws(f.readAsTextSync, (e) => e is FileIOException);
+    Expect.throws(f.readAsLinesSync, (e) => e is FileIOException);
+    // TODO(ager): Add tests of errors in readAsBytes when input
+    // streams are truely async.
+  }
 
   // Test that opens the same file for writing then for appending to test
   // that the file is not truncated when opened for appending.
   static void testAppend() {
     var file = new File('${tempDirectory.path}/out_append');
     file.openHandler = (openedFile) {
       openedFile.noPendingWriteHandler = () {
         openedFile.closeHandler = () {
           file.openHandler = (openedFile) {
             openedFile.lengthHandler = (length) {
@@ skipping 57 matching lines @@
     testRead();
     testReadSync();
     testReadStream();
     testLength();
     testLengthSync();
     testPosition();
     testPositionSync();
     testMixedSyncAndAsync();
     testOpenDirectoryAsFile();
     testOpenDirectoryAsFileSync();
+    testReadAsBytes();
+    testReadAsBytesSync();
+    testReadAsText();
+    testReadAsTextSync();
+    testReadAsLines();
+    testReadAsLinesSync();
+    testReadAsErrors();
 
     createTempDirectory(() {
       testReadWrite();
       testReadWriteSync();
       testReadWriteStream();
       testReadEmptyFileSync();
       testReadEmptyFile();
       testTruncate();
       testTruncateSync();
       testCloseException();
       testCloseExceptionStream();
       testBufferOutOfBoundsException();
       testAppend();
       testAppendSync();
       testWriteAppend();
       testOutputStreamWriteAppend();
       testWriteVariousLists();
       testDirectory();
       testDirectorySync();
     });
   }
 }
 
 main() {
   FileTest.testMain();
 }