Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: chrome/common/extensions/extension.h

Issue 9452008: Allow platform apps to specify a maximum size for the shell container. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: missing file Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/shell_window_views.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index fd224f2248760fcbf959be6938f53ff62198b36c..0f789ebbfaa96c75e0a350387bbf46de5cf38558 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -611,13 +611,21 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return launch_container_;
}
int launch_width() const {
- return std::max(launch_min_width_, launch_width_);
+ return std::max(launch_min_width_,
+ launch_max_width_ ?
+ std::min(launch_max_width_, launch_width_) :
+ launch_width_);
}
int launch_height() const {
- return std::max(launch_min_height_, launch_height_);
+ return std::max(launch_min_height_,
+ launch_max_height_ ?
+ std::min(launch_max_height_, launch_height_) :
+ launch_height_);
}
int launch_min_width() const { return launch_min_width_; }
int launch_min_height() const { return launch_min_height_; }
+ int launch_max_width() const { return launch_max_width_; }
+ int launch_max_height() const { return launch_max_height_; }
// Theme-related.
bool is_theme() const;
@@ -914,9 +922,12 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
int launch_width_;
int launch_height_;
- // The minimum size of the container. Only respected for the shell container.
+ // The minimum and maximum size of the container. Only respected for the
+ // shell container.
int launch_min_width_;
int launch_min_height_;
+ int launch_max_width_;
+ int launch_max_height_;
// The Omnibox keyword for this extension, or empty if there is none.
std::string omnibox_keyword_;
« no previous file with comments | « chrome/browser/ui/views/extensions/shell_window_views.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698