Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 9452008: Allow platform apps to specify a maximum size for the shell container. (Closed)

Created:
8 years, 10 months ago by jeremya
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, tfarina, mihaip+watch_chromium.org, ben+watch_chromium.org, benwells
Visibility:
Public.

Description

Allow platform apps to specify a maximum size for the shell container. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124380

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -8 lines) Patch
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 chunks +14 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/launch_container_invalid_size_constraints.json View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/window/non_client_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/non_client_view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jeremya
mihaip- all the files with 'extensions' in the path beng- all the files with 'views' ...
8 years, 10 months ago (2012-02-23 07:27:38 UTC) #1
Ben Goodger (Google)
browser/ui+views bits LGTM
8 years, 10 months ago (2012-02-23 17:14:32 UTC) #2
Mihai Parparita -not on Chrome
LGTM
8 years, 10 months ago (2012-02-23 18:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9452008/1
8 years, 10 months ago (2012-02-23 23:15:24 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/views/extensions/shell_window_views.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/views/extensions/shell_window_views.cc ...
8 years, 10 months ago (2012-02-23 23:15:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9452008/1
8 years, 9 months ago (2012-02-29 03:57:59 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/views/extensions/shell_window_views.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/views/extensions/shell_window_views.cc ...
8 years, 9 months ago (2012-02-29 03:58:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9452008/12001
8 years, 9 months ago (2012-03-01 01:28:30 UTC) #8
commit-bot: I haz the power
Try job failure for 9452008-12001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-01 01:57:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9452008/16004
8 years, 9 months ago (2012-03-01 02:52:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9452008/24001
8 years, 9 months ago (2012-03-01 03:20:35 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 07:23:22 UTC) #12
Change committed as 124380

Powered by Google App Engine
This is Rietveld 408576698