Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 9452007: Enable rar, tar, tar.gz and tar.bz2 archive support in CrOS file manager. (Closed)

Created:
8 years, 10 months ago by Ben Chan
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

Enable rar, tar, tar.gz and tar.bz2 archive support in CrOS file manager. This CL makes the following changes: 1. Change the CrOS file manager extension to handle rar, tar, tar.gz, tgz, tar.bz2, tbz, and tbz2 files in the same way that zip files are handled, so that they can be mounted as a virtual filesystem and expose their contents via the file manager. 2. Rename the 'Open zip file' button to 'Open'. 3. Remove unused IDS_FILE_BROWSER_UNMOUNT_ARCHIVE and ARCHIVES_REGEXP from code. BUG=chromium-os:26764 TEST=Build chromeos and test opening supported archive formats via file manager. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123315

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_type.js View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ben Chan
8 years, 10 months ago (2012-02-23 05:31:52 UTC) #1
tbarzic
On 2012/02/23 05:31:52, Ben Chan wrote: LGTM, but you'll also need owner lgtms for chrome/browser/extensions ...
8 years, 10 months ago (2012-02-23 05:51:55 UTC) #2
Ben Chan
+rginda and +asargent
8 years, 10 months ago (2012-02-23 06:00:02 UTC) #3
rginda
On 2012/02/23 06:00:02, Ben Chan wrote: > +rginda and +asargent lgtm
8 years, 10 months ago (2012-02-23 18:32:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/9452007/3001
8 years, 10 months ago (2012-02-23 18:44:39 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 20:45:46 UTC) #6
Change committed as 123315

Powered by Google App Engine
This is Rietveld 408576698