src/platform-freebsd.cc - Issue 9452002: Ensure that executable pages are properly guarded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-freebsd.cc

Issue 9452002: Ensure that executable pages are properly guarded. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform-freebsd.cc

diff --git a/src/platform-freebsd.cc b/src/platform-freebsd.cc

index a5981b19c3c11333247b103ec78a6376e30940b7..f6a426ff44be8fff1378e5fbe4b388b78a7ab9de 100644

--- a/src/platform-freebsd.cc

+++ b/src/platform-freebsd.cc

@@ -411,6 +411,12 @@ bool VirtualMemory::Uncommit(void* address, size_t size) {

}

+bool VirtualMemory::Guard(void* address) {

+ OS::Guard(address, OS::CommitPageSize());

+ return true;

Erik Corry 2012/02/23 12:00:40 You could have put this in the posix file.

void* VirtualMemory::ReserveRegion(size_t size) {

void* result = mmap(OS::GetRandomMmapAddr(),

size,