Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 9447090: Allow comments in extension config files. (Closed)

Created:
8 years, 10 months ago by cduvall
Modified:
8 years, 9 months ago
CC:
chris hebert , clark duvall , clinton staley , devlin cronin , matthew tytel , mitchell rosen , eriq augustine
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Allow comments in extension config files. Added a script to remove comments from the extension api JSON files before processing for the extension docs. We will now be able to comment in the JSON files, and they should be much easier to read. Also added the license header to all the JSON files. BUG=114233 TEST=Put comments in one of the JSON files and remake the docs. They will make with no problems. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124660 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124878

Patch Set 1 #

Patch Set 2 : Fixed small spelling error in README. #

Patch Set 3 : Deleted unnecessary comments in directory.py. #

Patch Set 4 : Added minify to some files in tools/json_schema_compiler #

Total comments: 3

Patch Set 5 : Pulled all of the logic into json_schema.py #

Patch Set 6 : Fixed up license headers to pass license tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -21 lines) Patch
M chrome/common/extensions/api/bookmarks.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/browserAction.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/browsingData.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/chromeAuthPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/chromePrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/chromeosInfoPrivate.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/contentSettings.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/contextMenus.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/cookies.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/debugger.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/devtools.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/devtools_api.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.accessibility.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.app.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.bookmarkManager.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.declarative.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.dns.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.downloads.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.extension.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.fonts.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.infobars.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.input.ui.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.input.virtualKeyboard.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.keybinding.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.processes.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.rlz.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.serial.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.socket.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.speechInput.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.topSites.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/fileBrowserHandler.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/fileBrowserPrivate.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/history.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/i18n.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/idle.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/input.ime.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/inputMethodPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/management.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/mediaPlayerPrivate.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/metricsPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/omnibox.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/pageAction.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/pageActions.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/pageCapture.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/permissions.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/privacy.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/proxy.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/storage.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/systemPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/terminalPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/test.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/tts.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/ttsEngine.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/types.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/webNavigation.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/webRequest.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/webSocketProxyPrivate.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/webstorePrivate.json View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/windows.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/build/directory.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/template/page_shell.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/json_minify/README View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/json_minify/README.chromium View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/json_minify/__init__.py View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/json_minify/minify-sans-regexp.js View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/json_minify/minify_json.py View 1 2 3 4 5 1 chunk +113 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 1 2 3 4 5 3 chunks +3 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator_test.py View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A tools/json_schema_compiler/json_schema.py View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/model_test.py View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/previewserver.py View 1 2 3 4 5 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
cduvall
8 years, 10 months ago (2012-02-25 20:54:39 UTC) #1
cduvall
CL for change to allow comments in JSON files. Thanks for the review.
8 years, 9 months ago (2012-02-29 02:16:20 UTC) #2
Aaron Boodman
Sweet! I think you will also need to change some files in tools/json_schema_compiler/ (just look ...
8 years, 9 months ago (2012-02-29 06:58:11 UTC) #3
cduvall
On 2012/02/29 06:58:11, Aaron Boodman wrote: > Sweet! > > I think you will also ...
8 years, 9 months ago (2012-03-02 01:19:24 UTC) #4
Aaron Boodman
LGTM, but I'd like kalman to double-check the changes to the schema compiler.
8 years, 9 months ago (2012-03-02 01:24:49 UTC) #5
not at google - send to devlin
https://chromiumcodereview.appspot.com/9447090/diff/7001/tools/json_schema_compiler/compiler.py File tools/json_schema_compiler/compiler.py (right): https://chromiumcodereview.appspot.com/9447090/diff/7001/tools/json_schema_compiler/compiler.py#newcode31 tools/json_schema_compiler/compiler.py:31: '/../../third_party/' Won't this cause problems on Windows? os.path.join. also ...
8 years, 9 months ago (2012-03-02 02:15:08 UTC) #6
not at google - send to devlin
By the way, I've frequently wanted comments in those schema files, so this is awesome.
8 years, 9 months ago (2012-03-02 02:18:35 UTC) #7
cduvall
Ok, I put all the logic in json_schema.py so we can just call LoadJSON(filename), and ...
8 years, 9 months ago (2012-03-02 02:53:25 UTC) #8
not at google - send to devlin
lgtm
8 years, 9 months ago (2012-03-02 03:01:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9447090/12002
8 years, 9 months ago (2012-03-02 03:15:33 UTC) #10
commit-bot: I haz the power
Change committed as 124660
8 years, 9 months ago (2012-03-02 16:09:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/9447090/20001
8 years, 9 months ago (2012-03-03 19:38:07 UTC) #12
cduvall
Had to recommit due to small license header problem.
8 years, 9 months ago (2012-03-03 19:38:49 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 21:20:17 UTC) #14
Change committed as 124878

Powered by Google App Engine
This is Rietveld 408576698