Issue 9447078: Reserve the bottom of the address space to prevent predictable alocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9447078: Reserve the bottom of the address space to prevent predictable alocations. (Closed)

Created:
8 years, 10 months ago by jschuh

Modified:
8 years, 9 months ago

Reviewers:
cpu_(ooo_6.6-7.5), rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reserve the bottom of the address space to prevent predictable alocations. BUG=113891 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123920

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	sandbox/src/target_process.cc	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jschuh

Should be self-explanatory. Windows gets very predictable with allocations at the bottom of the address ...

8 years, 10 months ago (2012-02-25 04:48:15 UTC) #1

rvargas (doing something else)

LGTM http://codereview.chromium.org/9447078/diff/1/sandbox/src/target_process.cc File sandbox/src/target_process.cc (right): http://codereview.chromium.org/9447078/diff/1/sandbox/src/target_process.cc#newcode48 sandbox/src/target_process.cc:48: const char* end = ptr + (limit & ...

8 years, 10 months ago (2012-02-27 22:47:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/9447078/5001

8 years, 9 months ago (2012-02-28 01:49:21 UTC) #3

Change committed as 123920

Expand Messages | Collapse Messages

Issue 9447078: Reserve the bottom of the address space to prevent predictable alocations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages