Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 9447066: [base] Make FilePathWatcher::Watch virtual so that it can be mocked. (Closed)

Created:
8 years, 10 months ago by szym
Modified:
8 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

[base] Make FilePathWatcher::Watch virtual so that it can be mocked. TEST=./base_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123563

Patch Set 1 #

Patch Set 2 : Make dtor virtual too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/files/file_path_watcher.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
szym
James, it would help us test NetworkChangeNotifier if FilePathWatcher could be mocked out. For example, ...
8 years, 10 months ago (2012-02-24 19:24:42 UTC) #1
szym
I first looked at git annotate, but just realized that jhawkins is not in OWNERS. ...
8 years, 10 months ago (2012-02-24 19:28:35 UTC) #2
dmac
lgtm
8 years, 10 months ago (2012-02-24 20:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/9447066/4
8 years, 10 months ago (2012-02-24 20:43:48 UTC) #4
szym
On 2012/02/24 20:42:18, dmac wrote: > lgtm Thanks a bunch.
8 years, 10 months ago (2012-02-24 20:44:00 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-24 22:18:53 UTC) #6
Change committed as 123563

Powered by Google App Engine
This is Rietveld 408576698