Issue 9447034: Android: Guard off desktop notifications

Issue 9447034: Android: Guard off desktop notifications (Closed)

Created:
8 years, 10 months ago by gone

Modified:
8 years, 9 months ago

Reviewers:
jam, willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Android: Guard off desktop notifications We currently have no system in place to perform desktop notifications on Android. This CL guards off certain bits of code and prevents the files in browser/notifications/* from being compiled when notifications are disabled. BUG=http://crbug.com/115320 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124305

Patch Set 1 #

Total comments: 3

Patch Set 2 : Guarding unused member variables #

Patch Set 3 : Rebasing #

Patch Set 4 : Fixing rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1 line)			Patch
M	build/common.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 2	7 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.h	View	1 2	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View	1 2	4 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

https://chromiumcodereview.appspot.com/9447034/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://chromiumcodereview.appspot.com/9447034/diff/1/chrome/browser/profiles/profile_io_data.cc#newcode228 chrome/browser/profiles/profile_io_data.cc:228: #if defined(ENABLE_NOTIFICATIONS) So...should you remove notification_service from ProfileParams when ...

8 years, 10 months ago (2012-02-24 02:33:21 UTC) #3

gone

8 years, 10 months ago (2012-02-24 02:58:29 UTC) #4

willchan no longer on Chromium

https://chromiumcodereview.appspot.com/9447034/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://chromiumcodereview.appspot.com/9447034/diff/1/chrome/browser/profiles/profile_io_data.cc#newcode228 chrome/browser/profiles/profile_io_data.cc:228: #if defined(ENABLE_NOTIFICATIONS) On 2012/02/24 02:58:29, dfalcantara wrote: > Yeah, ...

8 years, 10 months ago (2012-02-24 17:41:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/9447034/10002

8 years, 9 months ago (2012-02-29 19:26:31 UTC) #8

commit-bot: I haz the power

Can't apply patch for file chrome/chrome_browser.gypi. While running patch -p1 --forward --force; patching file chrome/chrome_browser.gypi ...

8 years, 9 months ago (2012-02-29 19:26:34 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/9447034/28001

8 years, 9 months ago (2012-02-29 21:23:30 UTC) #10

Change committed as 124305

Expand Messages | Collapse Messages