Fix compatibility with Xcode4.3 git

Fix compatibility with Xcode4.3 git

Xcode 4.3 git returns the version like below:

git version 1.7.7.5 (Apple Git-26)

Modify GIT.AssertVersion to accept such input.

Also modify tests/gclient_scm_test.py to pass tests, but not sure
the fix is collect.

BUG=chromium:115576
TEST=ran tests/gclient_scm_test.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123399

[bashi, 2012-02-24 01:31:06]

Hi maruel,

Could you please take a look?

[M-A Ruel, 2012-02-24 01:33:27]

lgtm with one optional nit

https://chromiumcodereview.appspot.com/9443047/diff/1/scm.py
File scm.py (right):

https://chromiumcodereview.appspot.com/9443047/diff/1/scm.py#newcode419
scm.py:419: matched = re.search('version (?P<version>[0-9.]+)', current_version)
using a named variable is a bit over IMHO, this would be sufficient:
match = re.search(r'version ([0-9\.]+)', current_version)

but I don't mind.

[bashi, 2012-02-24 01:39:58]

Thank you for review

http://codereview.chromium.org/9443047/diff/1/scm.py
File scm.py (right):

http://codereview.chromium.org/9443047/diff/1/scm.py#newcode419
scm.py:419: matched = re.search('version (?P<version>[0-9.]+)', current_version)
On 2012/02/24 01:33:27, Marc-Antoine Ruel wrote:
> using a named variable is a bit over IMHO, this would be sufficient:
> match = re.search(r'version ([0-9\.]+)', current_version)
> 
> but I don't mind.

Done.

[commit-bot: I haz the power, 2012-02-24 01:40:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bashi@chromium.org/9443047/3001

[commit-bot: I haz the power, 2012-02-24 01:47:02]

Change committed as 123399