Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: pylib/gyp/input.py

Issue 9443044: Beginnings of some msvs_... emulation (windows ninja) (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: no pdb option for LIB Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/input.py
diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py
index 74a96b6d8b8462670466f46b14055bab403acbc6..9392868d71a52f0e9efaedfd8ef6fb7e530008ec 100644
--- a/pylib/gyp/input.py
+++ b/pylib/gyp/input.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2011 Google Inc. All rights reserved.
+# Copyright (c) 2012 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -2152,6 +2152,9 @@ def ValidateActionsInTarget(target, target_dict, build_file):
"An action must have an 'action_name' field." %
target_name)
inputs = action.get('inputs', [])
+ action_command = action.get('action')
+ if action_command and not action_command[0]:
+ raise Exception("Empty action as command in target %s." % target_name)
def ValidateRunAsInTarget(target, target_dict, build_file):

Powered by Google App Engine
This is Rietveld 408576698