Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: gclient.py

Issue 9443025: Remove a check that would break with pinned revision using ssh protocol with a user name in the url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 7595893110accb713b303b11177873f7539fce02..5757d4229559a85770e07dc9f91634515abc59ec 100644
--- a/gclient.py
+++ b/gclient.py
@@ -168,8 +168,6 @@ class DependencySettings(GClientKeywords):
if isinstance(self._url, basestring):
# urls are sometime incorrectly written as proto://host/path/@rev. Replace
# it to proto://host/path@rev.
- if self._url.count('@') > 1:
- raise gclient_utils.Error('Invalid url "%s"' % self._url)
self._url = self._url.replace('/@', '@')
Peter Mayo 2012/02/23 20:32:56 I think the RFC precludes using slashes in the use
Peter Mayo 2012/02/23 20:49:57 1738 section 3.1 requires encoding of the @ and /
M-A Ruel 2012/02/23 20:50:07 As long as we make sure it doesn't work, it's fine
M-A Ruel 2012/02/23 20:51:04 The important part is that it'll fail to sync. Whi
elif not isinstance(self._url,
(self.FromImpl, self.FileImpl, None.__class__)):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698