Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 9442028: Make sure to remove color output from patches uploaded for try jobs (and other (Closed)

Created:
8 years, 10 months ago by Scott Byer
Modified:
8 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Make sure to remove color output from patches uploaded for try jobs (and other things). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scm.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Byer
Found another spot where color can mess things up.
8 years, 10 months ago (2012-02-23 21:06:57 UTC) #1
M-A Ruel
lgtm
8 years, 10 months ago (2012-02-23 21:08:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9442028/1
8 years, 10 months ago (2012-02-23 21:08:36 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 21:15:33 UTC) #4
Change committed as 123329

Powered by Google App Engine
This is Rietveld 408576698