Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/resources/options2/chromeos/internet_options.js

Issue 9442027: Add header to network details dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typos. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/chromeos/internet_options.js
diff --git a/chrome/browser/resources/options2/chromeos/internet_options.js b/chrome/browser/resources/options2/chromeos/internet_options.js
index 17424e21aa03babdf82faef6e31fea4a4330050d..b6d9fbc0c1032d1b69d9c221209f1ab16b425888 100644
--- a/chrome/browser/resources/options2/chromeos/internet_options.js
+++ b/chrome/browser/resources/options2/chromeos/internet_options.js
@@ -429,6 +429,15 @@ cr.define('options', function() {
InternetOptions.showDetailedInfo = function(data) {
var detailsPage = DetailsInternetPage.getInstance();
+
+ // Populate header
csilv 2012/02/25 01:31:54 add something like: var pageElement = $('details
kevers 2012/02/29 15:30:16 Updated header based on UX discussions.
+ var icon = $('detailsInternetPage').querySelector('.network-icon');
+ icon.style.backgroundImage = url(data.iconURL);
+ var title = $('detailsInternetPage').querySelector('.network-title');
+ title.textContent = data.networkName;
+ var subtitle = $('detailsInternetPage').querySelector('.network-subtitle');
+ subtitle.textContent = data.connectionState;
+
// TODO(chocobo): Is this hack to cache the data here reasonable?
$('connectionState').data = data;
$('buyplanDetails').hidden = true;

Powered by Google App Engine
This is Rietveld 408576698