Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: chrome/browser/resources/options2/chromeos/internet_options.js

Issue 9442027: Add header to network details dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add copyright notice. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/chromeos/internet_options.js
diff --git a/chrome/browser/resources/options2/chromeos/internet_options.js b/chrome/browser/resources/options2/chromeos/internet_options.js
index 17424e21aa03babdf82faef6e31fea4a4330050d..8fe7579f5e709842e6ebe705ed32c3a24f113d9b 100644
--- a/chrome/browser/resources/options2/chromeos/internet_options.js
+++ b/chrome/browser/resources/options2/chromeos/internet_options.js
@@ -429,6 +429,40 @@ cr.define('options', function() {
InternetOptions.showDetailedInfo = function(data) {
var detailsPage = DetailsInternetPage.getInstance();
+
+ // Populate header
+ $('network-details-title').textContent = data.networkName;
+ var statusKey = data.connected ? 'networkConnected' :
+ 'networkNotConnected';
+ $('network-details-subtitle-status').textContent =
+ localStrings.getString(statusKey);
+ var typeKey = null;
+ var Constants = options.internet.Constants;
+ switch (data.type) {
+ case Constants.TYPE_ETHERNET:
+ typeKey = 'ethernetTitle';
+ break;
+ case Constants.TYPE_WIFI:
+ typeKey = 'wifiTitle';
+ break;
+ case Constants.TYPE_CELLULAR:
+ typeKey = 'cellularTitle';
+ break;
+ case Constants.TYPE_VPN:
+ typeKey = 'vpnTitle';
+ break;
+ }
+ var typeLabel = $('network-details-subtitle-type');
+ var typeSeparator = $('network-details-subtitle-separator');
+ if (typeKey) {
+ typeLabel.textContent = localStrings.getString(typeKey);
+ typeLabel.hidden = false;
+ typeSeparator.hidden = false;
+ } else {
+ typeLabel.hidden = true;
+ typeSeparator.hidden = true;
+ }
+
// TODO(chocobo): Is this hack to cache the data here reasonable?
$('connectionState').data = data;
$('buyplanDetails').hidden = true;
@@ -443,11 +477,6 @@ cr.define('options', function() {
detailsPage.deviceConnected = data.deviceConnected;
detailsPage.connecting = data.connecting;
detailsPage.connected = data.connected;
- if (data.connected) {
- $('inetTitle').textContent = localStrings.getString('inetStatus');
- } else {
- $('inetTitle').textContent = localStrings.getString('inetConnect');
- }
$('connectionState').textContent = data.connectionState;
var inetAddress = '';
« no previous file with comments | « chrome/browser/resources/options2/chromeos/internet_detail.html ('k') | chrome/browser/resources/options2/options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698