Add header to network details dialog.

Add header to network details dialog.

BUG=chromium-os:19569
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124432

[kevers, 2012-02-23 21:06:21]

Hi Chris,

Can you please have a look at this CL.  It adds a header above the tab strip in
the internet details dialog that contains the network name, icon and status.

[csilv, 2012-02-25 01:31:53]

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_detail.html (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_detail.html:3: <div
class="content-area" id="internet-details-content-area">
nit: 'id' always comes first

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_details_page.css
(right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_details_page.css:21:
.subpages-nav-tabs#details-tab-strip {
This would probably be a better choice:
  #details-tab-strip.subpages-nav-tabs

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_options.js (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_options.js:433: // Populate
header
add something like:
  var pageElement = $('detailsInternetPage');

and then use that in place of $('detailsInternetPage') for this function.

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options.html (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options.html:47: <link rel="stylesheet"
href="chromeos/internet_details_page.css">
Please rename this "internet_details.css".  This keeps the html/css/js all
consistent.  We have a few voilations of this pattern that should be fixed
separately.

[kevers, 2012-02-29 15:30:14]

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_detail.html (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_detail.html:3: <div
class="content-area" id="internet-details-content-area">
On 2012/02/25 01:31:54, csilv wrote:
> nit: 'id' always comes first

Done.

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_details_page.css
(right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_details_page.css:21:
.subpages-nav-tabs#details-tab-strip {
On 2012/02/25 01:31:54, csilv wrote:
> This would probably be a better choice:
>   #details-tab-strip.subpages-nav-tabs

Done.

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/internet_options.js (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/internet_options.js:433: // Populate
header
On 2012/02/25 01:31:54, csilv wrote:
> add something like:
>   var pageElement = $('detailsInternetPage');
> 
> and then use that in place of $('detailsInternetPage') for this function.

Updated header based on UX discussions.

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options.html (right):

http://codereview.chromium.org/9442027/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options.html:47: <link rel="stylesheet"
href="chromeos/internet_details_page.css">
On 2012/02/25 01:31:54, csilv wrote:
> Please rename this "internet_details.css".  This keeps the html/css/js all
> consistent.  We have a few voilations of this pattern that should be fixed
> separately.

Renamed to internet_detail.css.  Though the plural form would be preferable, the
html and js files use the singular form.  Could update the names of all 3 files
in a separate CL.

[csilv, 2012-02-29 18:02:42]

lgtm

[commit-bot: I haz the power, 2012-03-01 13:30:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/9442027/9002

[commit-bot: I haz the power, 2012-03-01 13:30:53]

Presubmit check for 9442027-9002 failed and returned exit status 1.

/mnt/data/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/javascriptlintrules.py:28:
DeprecationWarning: the sets module is deprecated
  from sets import Set
Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

chrome/browser/resources/options2/chromeos/internet_detail.css:
- Use rgb() over #hex when not a shade of gray (like #333).
    color: #35ae47; (replace with rgb(53, 174, 71))

Send feedback or hate mail to dbeam@chromium.org

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  chrome/browser/resources/options2/chromeos/internet_detail.css

Presubmit checks took 3.0s to calculate.

[commit-bot: I haz the power, 2012-03-01 14:50:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/9442027/20001

[commit-bot: I haz the power, 2012-03-01 18:17:37]

Change committed as 124432