Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9433057: Extend image format support in third_party/icon_family (Closed)

Created:
8 years, 10 months ago by sail
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Extend image format support in third_party/icon_family This CL adds support for alpha first and non-premultiplied image formats. BUG=112651 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123155

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -33 lines) Patch
M third_party/icon_family/IconFamily.m View 10 chunks +73 lines, -33 lines 0 comments Download
M third_party/icon_family/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/icon_family/chromium_icon_family_2.patch View 1 chunk +189 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sail
I've sent a copy of this patch to the SourceForge project: https://sourceforge.net/tracker/?func=detail&aid=3491306&group_id=164783&atid=833111
8 years, 10 months ago (2012-02-22 20:57:04 UTC) #1
(unused - use chromium)
lgtm I hope compilers are good at inlining these days :-P But this is likely ...
8 years, 10 months ago (2012-02-22 21:04:07 UTC) #2
(unused - use chromium)
https://chromiumcodereview.appspot.com/9433057/diff/1/third_party/icon_family/README.chromium File third_party/icon_family/README.chromium (right): https://chromiumcodereview.appspot.com/9433057/diff/1/third_party/icon_family/README.chromium#newcode15 third_party/icon_family/README.chromium:15: chromium_icon_family_2.patch: Add support for alpha first and non-premultiplied image ...
8 years, 10 months ago (2012-02-22 21:04:54 UTC) #3
sail
https://chromiumcodereview.appspot.com/9433057/diff/1/third_party/icon_family/README.chromium File third_party/icon_family/README.chromium (right): https://chromiumcodereview.appspot.com/9433057/diff/1/third_party/icon_family/README.chromium#newcode15 third_party/icon_family/README.chromium:15: chromium_icon_family_2.patch: Add support for alpha first and non-premultiplied image ...
8 years, 10 months ago (2012-02-22 21:38:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9433057/2002
8 years, 10 months ago (2012-02-22 21:39:11 UTC) #5
commit-bot: I haz the power
Try job failure for 9433057-2002 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-22 22:59:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9433057/2002
8 years, 10 months ago (2012-02-22 23:01:11 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 00:48:45 UTC) #8
Change committed as 123155

Powered by Google App Engine
This is Rietveld 408576698