Make sure that chrome/ dir exists for webkit_unit_tests on Android.

Make sure that chrome/ dir exists for webkit_unit_tests on Android.

webkit_support::GetWebKitRootDirFilePath() looks for a chrome/ directory so
that it can identify this as a chrome working directory and therefore add
third_party/WebKit to the path to get the WebKit root dir. This normally
works because other unit tests pull in the chrome directory for their own
reasons, but if this is the first test run on a blank /data/local/tmp
directory, webkit_unit_test fails when it tries to load resources required
for the tests.

Pull in chrome/VERSION and thus ensure that the chrome/ directory exists.

TEST=webkit_unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123312

[Peter Beverloo, 2012-02-23 15:56:45]

webkit_unit_tests (WebKit target, should be in experimental) times out on the
AssociatedURLLoaderTest.SameOriginSuccess test (the RenderTableCellDeathTest
suite works well). This patch fixes it for jknotten on the Xoom, but does not
yield the same result for me on sojus/yakju.

There may be multiple problems going on here so the patch may be valid, but I
can't verify for now.

[Yaron, 2012-02-23 17:52:06]

http://codereview.chromium.org/9433049/diff/1/build/android/single_test_runne...
File build/android/single_test_runner.py (right):

http://codereview.chromium.org/9433049/diff/1/build/android/single_test_runne...
build/android/single_test_runner.py:192: 'chrome/VERSION',
Why don't we need this downstream? Is this due to a new change that hasn't
rolled in yet?

[John Knottenbelt, 2012-02-23 18:25:57]

We do need it downstream (and I already made that change). This change is only
required for when you start off wanting to run webkit_unit_tests without first
having run any  other tests that would bring in the chrome/ directory already. 

I think that the build bots downstream typically do have the chrome/ dir already
present.

On 2012/02/23 17:52:06, Yaron wrote:
>
http://codereview.chromium.org/9433049/diff/1/build/android/single_test_runne...
> File build/android/single_test_runner.py (right):
> 
>
http://codereview.chromium.org/9433049/diff/1/build/android/single_test_runne...
> build/android/single_test_runner.py:192: 'chrome/VERSION',
> Why don't we need this downstream? Is this due to a new change that hasn't
> rolled in yet?

[Yaron, 2012-02-23 18:29:18]

lgtm

[commit-bot: I haz the power, 2012-02-23 18:35:01]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bulach, 2012-02-23 18:38:56]

lgtm

thanks!

[commit-bot: I haz the power, 2012-02-23 18:39:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/9433049/1

[commit-bot: I haz the power, 2012-02-23 20:32:55]

Change committed as 123312