Add flag that enable Encrypted Media Extensions on video elements.

Add flag that enable Encrypted Media Extensions on video elements.

BUG=none
TEST=tested with flag enabled and disabled


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132896

[xhwang, 2012-02-22 18:17:26]

Hello ddorwin and scherkus,

This CL depends on (will be submitted after) the WebKit change. Please review.

xhwang

[ddorwin, 2012-02-22 19:08:26]

LGTM with nit.

I like grouping, but all this "MediaEncrypted" stuff (my fault) sounds horrible.
MediaDecryption is better but doesn't describe the feature. Back to
"EncryptedMedia", which is the real name of the W3C proposal?

http://codereview.chromium.org/9433046/diff/1/content/public/common/content_s...
File content/public/common/content_switches.cc (right):

http://codereview.chromium.org/9433046/diff/1/content/public/common/content_s...
content/public/common/content_switches.cc:252: // incomplete and this flag is
used for development and testing.
Is there an example of the second sentence in this file? I think it's just
likely to lead to code rot. Many flags are assumed to be for testing and
incomplete features I think.

[xhwang, 2012-02-22 19:15:57]

okay, will change back to "encrypted media" :-)

http://codereview.chromium.org/9433046/diff/1/content/public/common/content_s...
File content/public/common/content_switches.cc (right):

http://codereview.chromium.org/9433046/diff/1/content/public/common/content_s...
content/public/common/content_switches.cc:252: // incomplete and this flag is
used for development and testing.
On 2012/02/22 19:08:27, ddorwin wrote:
> Is there an example of the second sentence in this file? I think it's just
> likely to lead to code rot. Many flags are assumed to be for testing and
> incomplete features I think.

I basically borrowed this from VideoTrack (line 321).

[ddorwin, 2012-03-23 21:44:49]

lgtm

We can land this as soon as the first WebKit patch lands and WebKit DEPS has
been rolled.

[xhwang, 2012-04-17 20:07:59]

On 2012/03/23 21:44:49, ddorwin wrote:
> lgtm
> 
> We can land this as soon as the first WebKit patch lands and WebKit DEPS has
> been rolled.

Add OWNERS reviewers:

cpu@: chrome/app/*
sky@: content/browser/*, chrome/browser/*
joi@: content/public/*
piman@: content/renderer/*

[xhwang, 2012-04-17 20:15:26]

On 2012/04/17 20:07:59, xhwang wrote:
> On 2012/03/23 21:44:49, ddorwin wrote:
> > lgtm
> > 
> > We can land this as soon as the first WebKit patch lands and WebKit DEPS has
> > been rolled.
> 
> Add OWNERS reviewers:
> 
> cpu@: chrome/app/*
> sky@: content/browser/*, chrome/browser/*
> joi@: content/public/*
> piman@: content/renderer/*

Since this is a trivial change, it should be okay to have a common owner of
content/ and chrome/ to review this. Add ben@ as the only OWNERS reviewer for
all files in this issue. Sorry for the confusion.

[Ben Goodger (Google), 2012-04-17 20:55:34]

I'm not an owner of content/public. You want jam@

[xhwang, 2012-04-17 21:01:01]

On 2012/04/17 20:55:34, Ben Goodger (Google) wrote:
> I'm not an owner of content/public. You want jam@

Hello John,

Could you please do an owner review on this issue? Thanks!

xhwang

[Jói, 2012-04-17 21:06:03]

LGTM for content/public.

[sky, 2012-04-17 21:29:44]

LGTM

[xhwang, 2012-04-18 16:56:47]

On 2012/04/17 21:29:44, sky wrote:
> LGTM

Hello Ben,

jam@ is not online. Wondering if you could review the rest of this issue:
chrome/app/* and content/renderer/*. (joi@ and sky@ have reviewed their part.)

Thanks,
xhwang

[Ben Goodger (Google), 2012-04-18 20:35:11]

lgtm

[commit-bot: I haz the power, 2012-04-18 20:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/9433046/13001

[commit-bot: I haz the power, 2012-04-18 23:39:07]

Change committed as 132896