Fix extensions compile issues for Android on sync_unit_tests.

Fix extensions compile issues for Android on sync_unit_tests.

Get sync_unit_tests compiling with the chrome_browser.gypi extensions files included.
This required creating a stub for the ExtensionView for Android, but should be ok
as there are platform specific stubs already.  Still does not link, but progress.

BUG=113487
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123358

[John Grabowski, 2012-02-22 18:34:49]

Overall LG; minor tweaks requested

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_infobar_delegate.cc:46: // TODO(dtrainor):
This is not used.  Might need to pull this from Android UI
File a bug.  Assign to yourself.  Tag it somehow (e.g. click Extensions box and
add OS-Android).  Reference bug number here.

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_warning_set.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_warning_set.cc:115: if
(types.find(i->warning_type()) != types.end()) {
Alternate idea: make warning_type() a const method.

[David Trainor- moved to gerrit, 2012-02-22 19:10:19]

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_infobar_delegate.cc:46: // TODO(dtrainor):
This is not used.  Might need to pull this from Android UI
On 2012/02/22 18:34:49, John Grabowski wrote:
> File a bug.  Assign to yourself.  Tag it somehow (e.g. click Extensions box
and
> add OS-Android).  Reference bug number here.

Done.

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_warning_set.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_warning_set.cc:115: if
(types.find(i->warning_type()) != types.end()) {
On 2012/02/22 18:34:49, John Grabowski wrote:
> Alternate idea: make warning_type() a const method.

It's more that our port of stl doesn't support set::erase(const_iterator), only
set::erase(iterator).

[Yaron, 2012-02-22 19:34:24]

lgtm with nits

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
File chrome/browser/extensions/extension_host.h (right):

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
chrome/browser/extensions/extension_host.h:63: typedef ExtensionViewAndroid
PlatformExtensionView;
Aaron: when I added this we were originally going to completely remove
extensions as we have in our downstream fork but for the time being we'll have
extensions in the build to hopefully get us linking sooner. We may have to
revisit this but I just wanted to explain the change.

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
File chrome/browser/ui/android/extensions/extension_view_android.h (right):

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:15: Browser*
browser() const { return NULL; }
I think even dummy implementations are supposed to go in the cc file.

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:21:
ExtensionViewAndroid() { }
Need: DISALLOW_COPY_AND_ASSIGN(ExtensionViewAndroid);

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:25: 
Remove empty line

[John Grabowski, 2012-02-22 20:51:46]

LGTM from me as well

[David Trainor- moved to gerrit, 2012-02-22 21:31:32]

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
File chrome/browser/ui/android/extensions/extension_view_android.h (right):

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:15: Browser*
browser() const { return NULL; }
On 2012/02/22 19:34:24, Yaron wrote:
> I think even dummy implementations are supposed to go in the cc file.

This is inlined in the mac/gtk.  Trying to stay consistent.

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:21:
ExtensionViewAndroid() { }
On 2012/02/22 19:34:24, Yaron wrote:
> Need: DISALLOW_COPY_AND_ASSIGN(ExtensionViewAndroid);

Done.  Good catch :).

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/ui/an...
chrome/browser/ui/android/extensions/extension_view_android.h:25: 
On 2012/02/22 19:34:24, Yaron wrote:
> Remove empty line

Done.

[asargent_no_longer_on_chrome, 2012-02-22 21:47:55]

lgtm

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
File chrome/browser/extensions/extension_warning_set.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
chrome/browser/extensions/extension_warning_set.cc:114: for (iterator i =
warnings_.begin(); i != warnings_.end();) {
Out of curiousity, are you switching to using a non-const iterator here because
the call to erase below modifies the set?

[David Trainor- moved to gerrit, 2012-02-22 21:51:42]

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
File chrome/browser/extensions/extension_warning_set.cc (right):

https://chromiumcodereview.appspot.com/9433044/diff/4001/chrome/browser/exten...
chrome/browser/extensions/extension_warning_set.cc:114: for (iterator i =
warnings_.begin(); i != warnings_.end();) {
On 2012/02/22 21:47:55, Antony Sargent wrote:
> Out of curiousity, are you switching to using a non-const iterator here
because
> the call to erase below modifies the set?

It looks like our Android stl port of std::set doesn't have an erase method that
takes a const_iterator.  So this gives compile errors when I try to pass a
const_iterator to the erase call :(.

[commit-bot: I haz the power, 2012-02-23 01:12:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/9433044/3002

[commit-bot: I haz the power, 2012-02-23 01:12:46]

Presubmit check for 9433044-3002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/android/extensions/extension_view_android.cc,chrome/browser/ui/android/extensions/extension_view_android.h

Presubmit checks took 1.8s to calculate.

[David Trainor- moved to gerrit, 2012-02-23 02:05:49]

Ben: Please look at chrome/browser/ui/android/extensions files.  Need an owner
review.

[Ben Goodger (Google), 2012-02-23 05:54:30]

lgtm

[commit-bot: I haz the power, 2012-02-23 18:06:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/9433044/3002

[commit-bot: I haz the power, 2012-02-23 19:44:45]

Can't apply patch for file chrome/chrome_browser.gypi.
While running patch -p1 --forward --force;
patching file chrome/chrome_browser.gypi
Hunk #1 FAILED at 2561.
Hunk #2 succeeded at 4695 (offset 11 lines).
1 out of 2 hunks FAILED -- saving rejects to file chrome/chrome_browser.gypi.rej

[commit-bot: I haz the power, 2012-02-23 20:55:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/9433044/20001

[commit-bot: I haz the power, 2012-02-23 22:47:53]

Change committed as 123358