Delete Session and SessionManager object synchronously.

remoting/protocol/pepper_session_unittest.cc

Index: remoting/protocol/pepper_session_unittest.cc
diff --git a/remoting/protocol/pepper_session_unittest.cc b/remoting/protocol/pepper_session_unittest.cc
index f889984257171831b277c417495348e0e365d475..8eed5d56ef9b6f73c7728608a29205789e6c6857 100644
--- a/remoting/protocol/pepper_session_unittest.cc
+++ b/remoting/protocol/pepper_session_unittest.cc
@@ -226,7 +226,7 @@ class PepperSessionTest : public testing::Test {
     message_loop_.RunAllPending();
   }
 
-  void CreateChannel() {
+  void CreateChannel(bool expect_fail) {
     client_session_->CreateStreamChannel(kChannelName, base::Bind(
         &PepperSessionTest::OnClientChannelCreated, base::Unretained(this)));
     host_session_->CreateStreamChannel(kChannelName, base::Bind(
@@ -238,6 +238,13 @@ class PepperSessionTest : public testing::Test {
     EXPECT_CALL(host_channel_callback_, OnDone(_))
         .WillOnce(QuitThreadOnCounter(&counter));
     message_loop_.Run();
+
+    if (expect_fail) {
+      EXPECT_TRUE(!client_socket_.get() || host_socket_.get());

[Wez, 2012/02/23 19:33:42]

Do you mean !(client_socket_.get() || host_socket_.get()) here?

Given that you've written the expect success case as two EXPECT_TRUE()s you
could just have these be EXPECT_FALSE()?

[Sergey Ulanov, 2012/02/23 22:10:06]

I meant (!client_socket_.get()) || (!host_socket_.get()). Fixed.

+    } else {
+      EXPECT_TRUE(client_socket_.get());
+      EXPECT_TRUE(host_socket_.get());
+    }
   }
 
   JingleThreadMessageLoop message_loop_;
@@ -329,7 +336,7 @@ TEST_F(PepperSessionTest, TestStreamChannel) {
   ASSERT_NO_FATAL_FAILURE(
       InitiateConnection(1, FakeAuthenticator::ACCEPT, false));
 
-  ASSERT_NO_FATAL_FAILURE(CreateChannel());
+  ASSERT_NO_FATAL_FAILURE(CreateChannel(false));
 
   StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
                                 kMessageSize, kMessages);
@@ -344,7 +351,7 @@ TEST_F(PepperSessionTest, TestMultistepAuthStreamChannel) {
   ASSERT_NO_FATAL_FAILURE(
       InitiateConnection(3, FakeAuthenticator::ACCEPT, false));
 
-  ASSERT_NO_FATAL_FAILURE(CreateChannel());
+  ASSERT_NO_FATAL_FAILURE(CreateChannel(false));
 
   StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
                                 kMessageSize, kMessages);
@@ -353,5 +360,14 @@ TEST_F(PepperSessionTest, TestMultistepAuthStreamChannel) {
   tester.CheckResults();
 }
 
+// Verify that data can sent over stream channel.

[Wez, 2012/02/23 19:33:42]

typo: ... can be sent ...

[Sergey Ulanov, 2012/02/23 22:10:06]

The comment was incorrect.

+TEST_F(PepperSessionTest, TestFailedChannelAuth) {
+  CreateSessionManagers(1, FakeAuthenticator::ACCEPT);
+  ASSERT_NO_FATAL_FAILURE(
+      InitiateConnection(1, FakeAuthenticator::REJECT_CHANNEL, false));
+
+  ASSERT_NO_FATAL_FAILURE(CreateChannel(true));
+}
+
 }  // namespace protocol
 }  // namespace remoting