Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 9433023: roll breakpad 915:922 (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

roll breakpad 915:922 916: Creating minidump for uncaught exception on iOS. 917: Add missing include. (iOS) 918: Avoid setting an alternative stack for signals if there's already one (linux) 919: Add filename to error when PDBSourceLineWriter::Open fails (win) 920: Add some missing #includes 921: Add a bootstrap_register() wrapper to fix deprecation warnings (mac) 922: Move away from the 10.4 SDK. (mac) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122963

Patch Set 1 #

Patch Set 2 : gyp #

Total comments: 1

Patch Set 3 : no .h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
8 years, 10 months ago (2012-02-22 01:30:55 UTC) #1
Mark Mentovai
LGTM otherwise https://chromiumcodereview.appspot.com/9433023/diff/3/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://chromiumcodereview.appspot.com/9433023/diff/3/breakpad/breakpad.gyp#newcode34 breakpad/breakpad.gyp:34: 'src/common/mac/bootstrap_compat.h', This .gyp file, or at least ...
8 years, 10 months ago (2012-02-22 01:41:25 UTC) #2
Nico
Thanks! I removed the .h file.
8 years, 10 months ago (2012-02-22 01:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9433023/5002
8 years, 10 months ago (2012-02-22 01:46:06 UTC) #4
Mark Mentovai
LGTM
8 years, 10 months ago (2012-02-22 01:50:13 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-22 03:43:59 UTC) #6
Change committed as 122963

Powered by Google App Engine
This is Rietveld 408576698