Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/chrome_tests.gypi

Issue 9432033: Add experiments info to crash dumps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
===================================================================
--- chrome/chrome_tests.gypi (revision 125856)
+++ chrome/chrome_tests.gypi (working copy)
@@ -2515,6 +2515,86 @@
],
},
{
+ 'target_name': 'chrome_app_unittests',
+ 'type': 'executable',
+ 'dependencies': [
+ # unit tests should only depend on
+ # 1) everything that the chrome binaries depend on:
+ '<@(chromium_dependencies)',
+ # 2) test-specific support libraries:
+ '../testing/gmock.gyp:gmock',
+ '../testing/gtest.gyp:gtest',
+ 'test_support_common',
+ # 3) anything tests directly depend on
+ '../breakpad/breakpad.gyp:*',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'app/breakpad_win.cc',
+ 'app/breakpad_win_unittest.cc',
+ 'app/hard_error_handler_win.cc',
+ 'app/run_all_unittests.cc'
+ ],
+ 'conditions': [
+ ['OS=="mac"', {
+ # TODO(mark): We really want this for all non-static library targets,
+ # but when we tried to pull it up to the common.gypi level, it broke
+ # other things like the ui, startup, and page_cycler tests. *shrug*
+ 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
+
+ # libwebcore.a is so large that ld may not have a sufficiently large
+ # "hole" in its address space into which it can be mmaped by the
+ # time it reaches this library. As of May 10, 2010, libwebcore.a is
+ # about 1GB in some builds. In the Mac OS X 10.5 toolchain, using
+ # Xcode 3.1, ld is only a 32-bit executable, and address space
+ # exhaustion is the result, with ld failing and producing
+ # the message:
+ # ld: in .../libwebcore.a, can't map file, errno=12
+ #
+ # As a workaround, ensure that libwebcore.a appears to ld first when
+ # linking unit_tests. This allows the library to be mmapped when
+ # ld's address space is "wide open." Other libraries are small
+ # enough that they'll be able to "squeeze" into the remaining holes.
+ # The Mac linker isn't so sensitive that moving this library to the
+ # front of the list will cause problems.
+ #
+ # Enough pluses to make get this target prepended to the target's
+ # list of dependencies.
+ 'dependencies+++': [
+ '../third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp:webcore',
+ ],
+ }],
+ ['OS=="win"', {
+ 'conditions': [
+ ['win_use_allocator_shim==1', {
robertshield 2012/03/14 13:51:48 is this needed for a test executable?
MAD 2012/03/15 22:37:36 Dunno... I just copied that from other tests above
robertshield 2012/03/20 19:24:31 Nah, on further investigation, it might be needed.
+ 'dependencies': [
+ '<(allocator_target)',
+ ],
+ }],
+ ],
+ 'configurations': {
+ 'Debug_Base': {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ # Forcing incremental build off to try to avoid incremental
+ # linking errors on 64-bit bots too. http://crbug.com/52555
+ 'LinkIncremental': '1',
+ },
+ },
+ },
+ },
+ }, { # else: OS != "win"
+ 'sources!': [
+ 'app/breakpad_win.cc',
robertshield 2012/03/14 13:51:48 I think source files ending in _win.cc are already
MAD 2012/03/15 22:37:36 Again, I followed what I saw in other projects...
+ 'app/breakpad_win_unittest.cc',
robertshield 2012/03/14 13:51:48 I don't know if the same is true of win_unittest.c
MAD 2012/03/15 22:37:36 OK, I'll try that too... Thanks! Although the patt
robertshield 2012/03/20 19:24:31 Could be :-) Turns out that win_unittest is handle
+ 'app/hard_error_handler_win.cc',
+ ],
+ }],
+ ],
+ },
+ {
# Executable that runs each browser test in a new process.
'target_name': 'browser_tests',
'type': 'executable',

Powered by Google App Engine
This is Rietveld 408576698