Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9431002: Remove old TestServer constructor. (Closed)

Created:
8 years, 10 months ago by erikwright (departed)
Modified:
8 years, 9 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove old TestServer constructor. BUG=114369 TEST=everything still compiles and passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123859

Patch Set 1 #

Patch Set 2 : Apply correct constness. #

Patch Set 3 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M net/test/test_server.h View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M net/test/test_server.cc View 1 3 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
PTAL. Try failures are primarily due to the CF net tests failing (I did not ...
8 years, 10 months ago (2012-02-22 11:28:06 UTC) #1
Paweł Hajdan Jr.
LGTM
8 years, 10 months ago (2012-02-22 14:39:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9431002/8001
8 years, 10 months ago (2012-02-27 18:53:11 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-02-28 01:54:32 UTC) #4 
Change committed as 123859

Powered by Google App Engine
This is Rietveld 408576698