Makes the visual feedback for taking screenshot.

chrome/browser/ui/views/aura/screenshot_taker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/aura/screenshot_taker.h"
 
 #include <string>
 
+#include "ash/shell.h"
+#include "ash/shell_window_ids.h"
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/ui/window_snapshot/window_snapshot.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/aura/window.h"
+#include "ui/gfx/canvas.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_delegate.h"

[Daniel Erat, 2012/02/23 14:32:13]

you don't need these includes anymore; you should include
ui/gfx/compositor/layer.h instead, though

[Jun Mukai, 2012/02/24 00:38:28]

Done.

 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/user_manager.h"
 #endif
 
 namespace {
 std::string GetScreenshotFileName() {
   base::Time::Exploded now;
   base::Time::Now().LocalExplode(&now);
 
@@ skipping 27 matching lines @@
           screenshot_filename);
       if (!file_util::ReplaceFile(screenshot_path, real_path)) {
         LOG(ERROR) << "Failed to rename the file to " << real_path.value();
       }
     }
   } else {
     LOG(ERROR) << "Failed to save to " << screenshot_path.value();
   }
 }
 
+// How opaque should the window that we flash onscreen to provide visual

[Daniel Erat, 2012/02/23 14:32:13]

nit: s/window/layer here and in the const variable names

[Jun Mukai, 2012/02/24 00:38:28]

Done.

+// feedback after the screenshot is taken be?
+const unsigned char kVisualFeedbackWindowOpacity = 64;
+
+// How long should the visual feedback window be displayed?
+const uint64_t kVisualFeedbackWindowDisplayTimeMs = 100;
+
+void CleanupFeedbackView(ui::Layer* layer) {

[Daniel Erat, 2012/02/23 14:32:13]

s/CleanupFeedbackView/CloseFeedbackLayer/ ?

[Jun Mukai, 2012/02/24 00:38:28]

Done.

+  DCHECK(layer);
+  layer->SetVisible(false);
+  MessageLoopForUI::current()->DeleteSoon(FROM_HERE, layer);

[Daniel Erat, 2012/02/23 14:32:13]

you can delete it immediately instead of setting it invisible and posting this
task, i think

[Jun Mukai, 2012/02/24 00:38:28]

Done.

+}
+
+// Flashes the screen to provide visual feedback that a screenshot has
+// been taken.
+void DisplayVisualFeedback(const gfx::Rect& rect) {
+  ui::Layer* layer = new ui::Layer(ui::Layer::LAYER_SOLID_COLOR);

[Daniel Erat, 2012/02/23 14:32:13]

put this in a scoped_ptr in ScreenshotTaker so it doesn't get leaked if the
object is deleted before the delayed task runs?

[Jun Mukai, 2012/02/24 00:38:28]

Done.

+  layer->SetColor(SkColorSetA(SK_ColorWHITE, kVisualFeedbackWindowOpacity));
+  layer->SetBounds(rect);
+
+  ui::Layer* parent = ash::Shell::GetInstance()->GetContainer(
+      ash::internal::kShellWindowId_OverlayContainer)->layer();
+  parent->Add(layer);
+  parent->StackAtTop(layer);

[Daniel Erat, 2012/02/23 14:32:13]

i guess it doesn't hurt to be explicit, but i'm pretty sure that children are
already added at the top of the stack

[Jun Mukai, 2012/02/24 00:38:28]

Done.

+  layer->SetVisible(true);
+
+  MessageLoopForUI::current()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&CleanupFeedbackView, base::Unretained(layer)),
+      kVisualFeedbackWindowDisplayTimeMs);
+}
+
 }  // namespace
 
 ScreenshotTaker::ScreenshotTaker() {
 }
 
 void ScreenshotTaker::HandleTakePartialScreenshot(
     aura::Window* window, const gfx::Rect& rect) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   scoped_refptr<RefCountedBytes> png_data(new RefCountedBytes);
 
   bool is_logged_in = true;
 #if defined(OS_CHROMEOS)
   is_logged_in = chromeos::UserManager::Get()->user_is_logged_in();
 #endif
 
   if (browser::GrabWindowSnapshot(window, &png_data->data(), rect)) {
+    DisplayVisualFeedback(rect);
     content::BrowserThread::PostTask(
         content::BrowserThread::FILE, FROM_HERE,
         base::Bind(&SaveScreenshot, is_logged_in, png_data));
   } else {
     LOG(ERROR) << "Failed to grab the window screenshot";
   }
 }
 
 void ScreenshotTaker::HandleTakeScreenshot(aura::Window* window) {
   HandleTakePartialScreenshot(window, window->bounds());
 }