Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 9429052: Remove usage of a deprecated TestServer constructor. (Closed)

Created:
8 years, 10 months ago by erikwright (departed)
Modified:
8 years, 10 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove usage of a deprecated TestServer constructor. Hostname must now be explicitly specified (previously default was 127.0.0.1). See the following CL for further details: http://codereview.chromium.org/9369029/ A follow-up CL will remove the deprecated constructor: http://codereview.chromium.org/9431002/ BUG=114369 TEST=everything still compiles and passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/glue/unittest_test_server.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
8 years, 10 months ago (2012-02-22 15:57:02 UTC) #1
tony
LGTM
8 years, 10 months ago (2012-02-22 18:40:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9429052/1
8 years, 10 months ago (2012-02-22 18:42:58 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-22 20:14:34 UTC) #4
Change committed as 123095

Powered by Google App Engine
This is Rietveld 408576698