Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 9429039: Cleanup: Remove base::environment_vector and base::file_handle_mapping_vector to StudlyCaps. (Closed)

Created:
8 years, 10 months ago by Lei Zhang
Modified:
8 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, kkania, tfarina, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, robertshield, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove base::environment_vector and base::file_handle_mapping_vector to StudlyCaps. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123438

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -97 lines) Patch
M base/process_util.h View 1 2 3 5 chunks +7 lines, -8 lines 0 comments Download
M base/process_util_posix.cc View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download
M base/process_util_unittest.cc View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M base/test/multiprocess_test.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/multiprocess_test.cc View 1 2 3 3 chunks +3 lines, -8 lines 0 comments Download
MM chrome/app/nacl_fork_delegate_linux.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/app/nacl_fork_delegate_linux.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/mac/relauncher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_info_snapshot_mac_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/child_process_launcher.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/utility_process_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_tests.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M net/test/test_server_posix.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Lei Zhang
8 years, 10 months ago (2012-02-22 06:01:54 UTC) #1
Evan Martin
base lgtm, do you want me to look at the rest? you probably need to ...
8 years, 10 months ago (2012-02-22 07:04:11 UTC) #2
Lei Zhang
It's all either cookie cutter change or fixing lint errors. If you don't mind, feel ...
8 years, 10 months ago (2012-02-22 07:16:37 UTC) #3
jam
content lgtm this always bothered me, thanks for cleaning it up!
8 years, 10 months ago (2012-02-22 16:12:10 UTC) #4
Lei Zhang
willchan: OWNERS for base and net abodenha: OWNERS for chrome/browser/printing/cloud_print
8 years, 10 months ago (2012-02-22 19:36:00 UTC) #5
Albert Bodenhamer
lgtm Reviewed cloud print code only.
8 years, 10 months ago (2012-02-22 19:37:36 UTC) #6
Evan Martin
LGTM for whole thing
8 years, 10 months ago (2012-02-22 20:41:38 UTC) #7
willchan no longer on Chromium
lgtm
8 years, 10 months ago (2012-02-22 23:42:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9429039/5006
8 years, 10 months ago (2012-02-22 23:43:31 UTC) #9
commit-bot: I haz the power
Can't apply patch for file content/browser/ppapi_plugin_process_host.cc. While running patch -p0 --forward --force; patching file content/browser/ppapi_plugin_process_host.cc ...
8 years, 10 months ago (2012-02-22 23:43:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9429039/11001
8 years, 10 months ago (2012-02-23 01:54:05 UTC) #11
commit-bot: I haz the power
Try job failure for 9429039-11001 (retry) on android for steps "build, Compile". It's a second ...
8 years, 10 months ago (2012-02-23 02:02:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9429039/16015
8 years, 10 months ago (2012-02-24 02:58:24 UTC) #13
commit-bot: I haz the power
8 years, 10 months ago (2012-02-24 04:40:22 UTC) #14
Change committed as 123438

Powered by Google App Engine
This is Rietveld 408576698