Integrate the new DomStorage backend into DRT and test_shell.

webkit/tools/test_shell/test_webview_delegate.cc

Index: webkit/tools/test_shell/test_webview_delegate.cc
===================================================================
--- webkit/tools/test_shell/test_webview_delegate.cc	(revision 123798)
+++ webkit/tools/test_shell/test_webview_delegate.cc	(working copy)
@@ -70,6 +70,7 @@
 #include "webkit/tools/test_shell/mock_spellcheck.h"
 #include "webkit/tools/test_shell/notification_presenter.h"
 #include "webkit/tools/test_shell/simple_appcache_system.h"
+#include "webkit/tools/test_shell/simple_dom_storage_system.h"
 #include "webkit/tools/test_shell/simple_file_system.h"
 #include "webkit/tools/test_shell/test_navigation_controller.h"
 #include "webkit/tools/test_shell/test_shell.h"
@@ -333,9 +334,13 @@
 
 WebStorageNamespace* TestWebViewDelegate::createSessionStorageNamespace(

[michaeln, 2012/02/28 06:04:23]

Oh well...

My assumption that this was utilized in chromiumDRT was wrong. this is only used
in test_shell. i'll have to create another code path for DRT to invoke the
SimplDomStorageSystem's CreateSessionStorageNamespace() factory method.

I missed the impl of WebViewClient::createSessionStorageNamespace(unsigned
quota) in this file... WebKit/Tools/DumpRenderTree/chromium/WebViewHost.cpp

I'll have to add something to webkit/support/webkit_support.h which is where DRT
calls out to invoke logic that's implemented in chromium.

Unfortunately, this'll be a two-sided patch to update WebViewHost.cpp in
webkit's svn repository.
- add an interface and impl to webkit_support (chromium svn)
- retrofit WebViewHost.cpp to use that new interface (webkit svn)

I can add that first part to this CL, but w/o having the upstream part done, i
can't run layout tests on the try bots (although i can run them on my local
system with WebViewHost changes made here). So long as its commited with the
ENABLE flag turned of, nothing will break.

     unsigned quota) {
+#ifdef ENABLE_NEW_DOM_STORAGE_BACKEND
+  return SimpleDomStorageSystem::instance().CreateSessionStorageNamespace();
+#else
   // Enforce quota, ignoring the parameter from WebCore as in Chrome.
   return WebKit::WebStorageNamespace::createSessionStorageNamespace(
       WebStorageNamespace::m_sessionStorageQuota);
+#endif
 }
 
 WebGraphicsContext3D* TestWebViewDelegate::createGraphicsContext3D(