Integrate the new DomStorage backend into DRT and test_shell.

webkit/support/test_webkit_platform_support.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/support/test_webkit_platform_support.h"
 
 #include "base/file_util.h"
 #include "base/metrics/stats_counters.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 301 matching lines @@
   if (name == WebKit::WebLocalizedString::ValidationStepMismatch)
     return ASCIIToUTF16("step mismatch");
   return WebKitPlatformSupportImpl::queryLocalizedString(name, value1, value2);
 }
 
 WebKit::WebString TestWebKitPlatformSupport::defaultLocale() {
   return ASCIIToUTF16("en-US");
 }
 
 WebKit::WebStorageNamespace*
 TestWebKitPlatformSupport::createLocalStorageNamespace(

[benm (inactive), 2012/02/23 19:17:15]

Just wondering, why does this class not define a method for getting
SessionStorage? I guess it picks it up from webview_delegate? But why the split?

[michaeln, 2012/02/25 19:20:32]

Direct consequence of how webcore and ultimately the webkit API is put together,
this just implements that.

local storage namespaces are created w/o any 'context' whereas session storage
namespaces are contextual. The API reflects that by making the factory method
for local guys global and that for session guys an instance method of an
interface that implies the extra context.

     const WebKit::WebString& path, unsigned quota) {
+#ifdef ENABLE_NEW_DOM_STORAGE_BACKEND
+  return dom_storage_system_.CreateLocalStorageNamespace();
+#else
   return WebKit::WebStorageNamespace::createLocalStorageNamespace(path, quota);
+#endif
 }
 
 void TestWebKitPlatformSupport::dispatchStorageEvent(
     const WebKit::WebString& key,
     const WebKit::WebString& old_value, const WebKit::WebString& new_value,
     const WebKit::WebString& origin, const WebKit::WebURL& url,
     bool is_local_storage) {
-  // The event is dispatched by the proxy.
+  // All events are dispatched by the WebCore::StorageAreaProxy in the
+  // simple single process case.
+  NOTREACHED();
 }
 
 WebKit::WebIDBFactory* TestWebKitPlatformSupport::idbFactory() {
   return WebKit::WebIDBFactory::create();
 }
 
 void TestWebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath(
       const WebKit::WebVector<WebKit::WebSerializedScriptValue>& values,
       const WebKit::WebString& keyPath,
       WebKit::WebVector<WebKit::WebIDBKey>& keys_out) {
@@ skipping 99 matching lines @@
     const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info) {
   return SimpleResourceLoaderBridge::Create(request_info);
 }
 
 webkit_glue::WebSocketStreamHandleBridge*
 TestWebKitPlatformSupport::CreateWebSocketBridge(
     WebKit::WebSocketStreamHandle* handle,
     webkit_glue::WebSocketStreamHandleDelegate* delegate) {
   return SimpleSocketStreamBridge::Create(handle, delegate);
 }